From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>, Avi Kivity <avi@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
"hugh.dickins" <hugh.dickins@tiscali.co.uk>,
David Howells <dhowells@redhat.com>,
lkml <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [RFC][PATCH] kmap_atomic_push
Date: Thu, 8 Oct 2009 17:53:44 +0200 [thread overview]
Message-ID: <20091008155344.GA11727@elte.hu> (raw)
In-Reply-To: <1255016123.17055.17.camel@laptop>
* Peter Zijlstra <peterz@infradead.org> wrote:
> The below patchlet changes the kmap_atomic interface to a stack based
> one that doesn't require the KM_types anymore.
>
> This significantly simplifies some code (more still than are present
> in this patch -- ie. pte_map_nested can go now)
>
> This obviously requires that push and pop are matched, I fixed a few
> cases that were not properly nested, the (x86) code checks for this
> and will go BUG when trying to pop a vaddr that isn't the top one so
> abusers should be rather visible.
Looks great IMO! Last i proposed this i think either Andrew or Avi had
second thoughts about the hard-to-calculate worst-case mapping limit -
but i dont think that's a big issue.
Lets not change the API names though - the rule is that map/unmap must
be properly nested.
Ingo
next prev parent reply other threads:[~2009-10-08 15:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-08 15:35 [RFC][PATCH] kmap_atomic_push Peter Zijlstra
2009-10-08 15:44 ` Linus Torvalds
2009-10-08 15:53 ` Ingo Molnar [this message]
2009-10-08 16:29 ` Peter Zijlstra
2009-10-08 16:50 ` Linus Torvalds
2009-10-08 18:02 ` Hugh Dickins
2009-10-08 22:27 ` jim owens
2009-10-08 22:32 ` Peter Zijlstra
2009-10-08 22:57 ` Peter Zijlstra
2009-10-09 12:15 ` jim owens
2009-10-08 22:12 ` David Howells
2009-10-08 22:29 ` Peter Zijlstra
2009-10-08 22:58 ` David Howells
2009-10-08 22:42 ` Peter Zijlstra
2009-10-12 18:10 ` Andi Kleen
2009-10-12 18:30 ` Linus Torvalds
2009-10-12 18:40 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008155344.GA11727@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=dhowells@redhat.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox