From: Andres Salomon <dilinger@collabora.co.uk>
To: wuzhangjin@gmail.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mips <linux-mips@linux-mips.org>,
Jaya Kumar <jayakumar.lkml@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
loongson-dev@googlegroups.com
Subject: Re: [PATCH] CS5535: Remove the X86 platform dependence of SND_CS5535AUDIO
Date: Fri, 9 Oct 2009 00:53:18 -0400 [thread overview]
Message-ID: <20091009005318.7174938c@mycelium.queued.net> (raw)
In-Reply-To: <1255060287.16819.1.camel@falcon>
On Fri, 09 Oct 2009 11:51:27 +0800
Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote:
> > There is no platform dependence of SND_CS5535AUDIO before 2.6.31,
> > Not sure who have touched this part, but SND_CS5535AUDIO is at least
> > available on Loongson family machines, so, Remove the platform
> > dependence directly.
> >
> > Reported-by: rixed@happyleptic.org
> > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> > ---
> > sound/pci/Kconfig | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
> > index fb5ee3c..75c602b 100644
> > --- a/sound/pci/Kconfig
> > +++ b/sound/pci/Kconfig
> > @@ -259,7 +259,6 @@ config SND_CS5530
> >
> > config SND_CS5535AUDIO
> > tristate "CS5535/CS5536 Audio"
> > - depends on X86 && !X86_64
>
> or use this?
>
> depends on (X86 && !X86_64) || MIPS
>
> Regards,
> Wu Zhangjin
>
I'd say just remove the arch dependency (and make sure it builds and
doesn't obviously explode w/ x86-64). There's no need for it, afaict.
It's been there since at least 2005 (git commit 230b5c1a).
next prev parent reply other threads:[~2009-10-09 5:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 3:44 [PATCH] CS5535: Remove the X86 platform dependence of SND_CS5535AUDIO Wu Zhangjin
2009-10-09 3:51 ` Wu Zhangjin
2009-10-09 4:53 ` Andres Salomon [this message]
2009-10-10 14:32 ` Wu Zhangjin
2009-10-10 15:34 ` Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009005318.7174938c@mycelium.queued.net \
--to=dilinger@collabora.co.uk \
--cc=jayakumar.lkml@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=loongson-dev@googlegroups.com \
--cc=perex@perex.cz \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox