* [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save()
@ 2009-10-09 9:41 Jiri Kosina
2009-10-09 10:52 ` Jesper Nilsson
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2009-10-09 9:41 UTC (permalink / raw)
To: Mikael Starvik, Jesper Nilsson, linux-cris-kernel; +Cc: linux-kernel
[ This is just FYI. I have already queued this one in trivial tree. ]
This is a followup to my patches that fixed this all over the tree quite some
time ago. This one went unnoticed for some reason.
TLB handling for CRIS contains local_irq_disable() after local_save_flags().
Turn this into local_irq_save().
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
arch/cris/arch-v10/mm/fault.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/arch/cris/arch-v10/mm/fault.c b/arch/cris/arch-v10/mm/fault.c
index 087a209..ed60588 100644
--- a/arch/cris/arch-v10/mm/fault.c
+++ b/arch/cris/arch-v10/mm/fault.c
@@ -80,8 +80,7 @@ handle_mmu_bus_fault(struct pt_regs *regs)
* do_page_fault may have flushed the TLB so we have to restore
* the MMU registers.
*/
- local_save_flags(flags);
- local_irq_disable();
+ local_irq_save(flags);
pmd = (pmd_t *)(pgd + pgd_index(address));
if (pmd_none(*pmd))
goto exit;
--
1.5.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save()
2009-10-09 9:41 [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save() Jiri Kosina
@ 2009-10-09 10:52 ` Jesper Nilsson
2009-10-09 12:15 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Jesper Nilsson @ 2009-10-09 10:52 UTC (permalink / raw)
To: Jiri Kosina
Cc: Mikael Starvik, linux-cris-kernel, linux-kernel@vger.kernel.org
On Fri, Oct 09, 2009 at 11:41:03AM +0200, Jiri Kosina wrote:
> [ This is just FYI. I have already queued this one in trivial tree. ]
> This is a followup to my patches that fixed this all over the tree quite some
> time ago. This one went unnoticed for some reason.
>
> TLB handling for CRIS contains local_irq_disable() after local_save_flags().
> Turn this into local_irq_save().
Thanks, that looks good.
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save()
2009-10-09 10:52 ` Jesper Nilsson
@ 2009-10-09 12:15 ` Jiri Kosina
2009-10-09 12:46 ` Jesper Nilsson
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2009-10-09 12:15 UTC (permalink / raw)
To: Jesper Nilsson
Cc: Mikael Starvik, linux-cris-kernel, linux-kernel@vger.kernel.org
On Fri, 9 Oct 2009, Jesper Nilsson wrote:
> > This is a followup to my patches that fixed this all over the tree quite some
> > time ago. This one went unnoticed for some reason.
> >
> > TLB handling for CRIS contains local_irq_disable() after local_save_flags().
> > Turn this into local_irq_save().
>
> Thanks, that looks good.
I will then add
Acked-by: Jesper Nilsson <Jesper.Nilsson@axis.com>
to it if you don't mind (the same for the old debug stuff removal).
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save()
2009-10-09 12:15 ` Jiri Kosina
@ 2009-10-09 12:46 ` Jesper Nilsson
0 siblings, 0 replies; 4+ messages in thread
From: Jesper Nilsson @ 2009-10-09 12:46 UTC (permalink / raw)
To: Jiri Kosina
Cc: Mikael Starvik, linux-cris-kernel, linux-kernel@vger.kernel.org
On Fri, Oct 09, 2009 at 02:15:34PM +0200, Jiri Kosina wrote:
> On Fri, 9 Oct 2009, Jesper Nilsson wrote:
> > > This is a followup to my patches that fixed this all over the tree quite some
> > > time ago. This one went unnoticed for some reason.
> > > TLB handling for CRIS contains local_irq_disable() after local_save_flags().
> > > Turn this into local_irq_save().
> >
> > Thanks, that looks good.
>
> I will then add
>
> Acked-by: Jesper Nilsson <Jesper.Nilsson@axis.com>
>
> to it if you don't mind (the same for the old debug stuff removal).
Absolutely, and thank you. :-)
> Thanks,
> Jiri Kosina
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-10-09 12:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-09 9:41 [PATCH] CIRS: turn local_save_flags() + local_irq_disable()into local_irq_save() Jiri Kosina
2009-10-09 10:52 ` Jesper Nilsson
2009-10-09 12:15 ` Jiri Kosina
2009-10-09 12:46 ` Jesper Nilsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox