From: Greg KH <greg@kroah.com>
To: Steve Friedl <steve@unixwiz.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] staging: hv: Changed |typedef RING_BUFFER| to |struct hv_ring_buffer| throughout.
Date: Fri, 9 Oct 2009 09:23:19 -0700 [thread overview]
Message-ID: <20091009162319.GC2766@kroah.com> (raw)
In-Reply-To: <20090922054026.GA5959@dcent.unixwiz.lan>
On Mon, Sep 21, 2009 at 10:40:26PM -0700, Steve Friedl wrote:
> The style guide (and Greg's prior work) have suggested that the typedef
> UPPERCASENAME style is not appropriate in the Linux kernel (even though
> it's been de rigueur in Win32 development for 20 years), so I'm fixing
> a couple more of them that remain... one at a time.
>
> ~~~ Steve
>
> Signed-off-by: Steve Friedl <steve@unixwiz.net>
>
> ---
> drivers/staging/hv/RingBuffer.c | 6 +++---
I'd rather not polish this turd anymore. Can someone just replace the
ringbuffer.c code by using the in-kernel ringbuffer or kfifo code
instead? I'd love to just delete this file completly, it does not
belong in the tree at all.
thanks,
greg k-h
prev parent reply other threads:[~2009-10-09 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 5:40 [PATCH 2/8] staging: hv: Changed |typedef RING_BUFFER| to |struct hv_ring_buffer| throughout Steve Friedl
2009-09-22 13:05 ` Arnd Bergmann
2009-10-09 16:23 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009162319.GC2766@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steve@unixwiz.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).