From: Johan Hovold <jhovold@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Johan Hovold <jhovold@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-usb@vger.kernel.org, e9hack <e9hack@googlemail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: Fix read regression in 2.6.31.
Date: Fri, 9 Oct 2009 20:41:13 +0200 [thread overview]
Message-ID: <20091009184113.GE21054@localhost> (raw)
In-Reply-To: <20091009175602.GC5718@kroah.com>
On Fri, Oct 09, 2009 at 10:56:02AM -0700, Greg KH wrote:
> On Sun, Sep 20, 2009 at 10:18:36PM +0200, Johan Hovold wrote:
> > Use ASYNCB_INITIALIZED to determine when to stop reading.
> >
> > Port count can no longer be used to determine when to stop reading from
> > the device as it can be zero when the first read callbacks are made (see
> > tty_port_block_til_read where port count is temporarily decremented
> > during serial_open).
> >
> > Signed-off-by: Johan Hovold <jhovold@gmail.com>
> > ---
> >
> > Hi,
> >
> > Here's a patch which fixes the port count issue for all drivers. I only
> > have access to an ftdi device at the moment so that's the only driver
> > I've been able to test (against latest git with latest patches from
> > Greg's tree).
>
> Hm, this doesn't apply on top of the other ftdi patches. Could you
> respin this?
There were some issues with that patch, so please disregard that one.
Sorry. There are probably still some problems with some of the other
drivers (at least theoretical ones) due to the tty changes that broke
ftdi, but there is currently no patch to fix them all.
/Johan
next prev parent reply other threads:[~2009-10-09 18:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090916162640.2840db66@lxorguk.ukuu.org.uk>
2009-09-19 16:03 ` [PATCH] USB: ftdi_sio: Fix read regression in 2.6.31 Johan Hovold
2009-09-19 16:20 ` Alan Stern
2009-09-19 16:36 ` Johan Hovold
2009-09-20 20:18 ` [PATCH] USB: serial: " Johan Hovold
2009-10-09 17:56 ` Greg KH
2009-10-09 18:41 ` Johan Hovold [this message]
2009-10-09 19:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091009184113.GE21054@localhost \
--to=jhovold@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=e9hack@googlemail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox