From: Pavel Machek <pavel@ucw.cz>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: rjw@sisk.pl, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] PM / Hibernate: fix error handling in save_image
Date: Sat, 10 Oct 2009 14:17:23 +0200 [thread overview]
Message-ID: <20091010121723.GC1943@ucw.cz> (raw)
In-Reply-To: <1255175505-7756-1-git-send-email-jirislaby@gmail.com>
On Sat 2009-10-10 13:51:45, Jiri Slaby wrote:
> There are too many retval variables in save_image. Thus error return
> value from snapshot_read_next may be ignored and only part of the
> snapshot (successfully) written.
>
> Remove 'error' variable, invert the condition in the do-while loop
> and convert the loop to use only 'ret' variable.
>
> Switch the rest of the function to consider only 'ret'.
>
> Also make sure we end printed line by \n if an error occurs.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
ACK.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-10-10 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 11:51 [PATCH 1/1] PM / Hibernate: fix error handling in save_image Jiri Slaby
2009-10-10 12:17 ` Pavel Machek [this message]
2009-10-28 22:08 ` Rafael J. Wysocki
2009-10-12 21:29 ` Jiri Slaby
2009-10-12 21:38 ` [PATCH 1/1] PM / Hibernate: add \n to load_image fail path Jiri Slaby
2009-10-13 7:28 ` Pavel Machek
2009-10-28 22:08 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091010121723.GC1943@ucw.cz \
--to=pavel@ucw.cz \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox