* [PATCH] sysfs: mark a locally-only used function static
@ 2009-10-11 1:02 Stefan Richter
2009-10-11 4:42 ` Greg KH
2009-10-13 14:42 ` David P. Quigley
0 siblings, 2 replies; 6+ messages in thread
From: Stefan Richter @ 2009-10-11 1:02 UTC (permalink / raw)
To: James Morris; +Cc: David P. Quigley, Stephen D. Smalley, linux-kernel
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
index e28cecf..e144351 100644
--- a/fs/sysfs/inode.c
+++ b/fs/sysfs/inode.c
@@ -46,7 +46,7 @@ int __init sysfs_inode_init(void)
return bdi_init(&sysfs_backing_dev_info);
}
-struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
+static struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
{
struct sysfs_inode_attrs *attrs;
struct iattr *iattrs;
@@ -64,6 +64,7 @@ struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
return attrs;
}
+
int sysfs_setattr(struct dentry * dentry, struct iattr * iattr)
{
struct inode * inode = dentry->d_inode;
--
Stefan Richter
-=====-==--= =-=- -=-==
http://arcgraph.de/sr/
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] sysfs: mark a locally-only used function static
2009-10-11 1:02 [PATCH] sysfs: mark a locally-only used function static Stefan Richter
@ 2009-10-11 4:42 ` Greg KH
2009-10-11 7:52 ` Stefan Richter
2009-10-13 14:42 ` David P. Quigley
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2009-10-11 4:42 UTC (permalink / raw)
To: Stefan Richter
Cc: James Morris, David P. Quigley, Stephen D. Smalley, linux-kernel
On Sun, Oct 11, 2009 at 03:02:46AM +0200, Stefan Richter wrote:
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Odd you didn't cc: the sysfs maintainer on this patch. Any reason?
scripts/get_maintainer.pl is your friend...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sysfs: mark a locally-only used function static
2009-10-11 4:42 ` Greg KH
@ 2009-10-11 7:52 ` Stefan Richter
2009-10-12 22:10 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Richter @ 2009-10-11 7:52 UTC (permalink / raw)
To: Greg KH; +Cc: James Morris, David P. Quigley, Stephen D. Smalley, linux-kernel
Greg KH wrote:
> On Sun, Oct 11, 2009 at 03:02:46AM +0200, Stefan Richter wrote:
>> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
>
> Odd you didn't cc: the sysfs maintainer on this patch. Any reason?
>
> scripts/get_maintainer.pl is your friend...
Sheer laziness. I trusted that those who introduced this function would
handle it for me.
--
Stefan Richter
-=====-==--= =-=- -=-==
http://arcgraph.de/sr/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sysfs: mark a locally-only used function static
2009-10-11 7:52 ` Stefan Richter
@ 2009-10-12 22:10 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2009-10-12 22:10 UTC (permalink / raw)
To: Stefan Richter
Cc: James Morris, David P. Quigley, Stephen D. Smalley, linux-kernel
On Sun, Oct 11, 2009 at 09:52:20AM +0200, Stefan Richter wrote:
> Greg KH wrote:
> > On Sun, Oct 11, 2009 at 03:02:46AM +0200, Stefan Richter wrote:
> >> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> >
> > Odd you didn't cc: the sysfs maintainer on this patch. Any reason?
> >
> > scripts/get_maintainer.pl is your friend...
>
> Sheer laziness. I trusted that those who introduced this function would
> handle it for me.
Cool, I'll be lazy and not apply it as it was not addressed to me :)
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sysfs: mark a locally-only used function static
2009-10-11 1:02 [PATCH] sysfs: mark a locally-only used function static Stefan Richter
2009-10-11 4:42 ` Greg KH
@ 2009-10-13 14:42 ` David P. Quigley
2009-10-14 18:47 ` [PATCH resend] " Stefan Richter
1 sibling, 1 reply; 6+ messages in thread
From: David P. Quigley @ 2009-10-13 14:42 UTC (permalink / raw)
To: Stefan Richter; +Cc: James Morris, Stephen D. Smalley, linux-kernel, greg
On Sun, 2009-10-11 at 03:02 +0200, Stefan Richter wrote:
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
> diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
> index e28cecf..e144351 100644
> --- a/fs/sysfs/inode.c
> +++ b/fs/sysfs/inode.c
> @@ -46,7 +46,7 @@ int __init sysfs_inode_init(void)
> return bdi_init(&sysfs_backing_dev_info);
> }
>
> -struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
> +static struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
> {
> struct sysfs_inode_attrs *attrs;
> struct iattr *iattrs;
> @@ -64,6 +64,7 @@ struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
>
> return attrs;
> }
> +
> int sysfs_setattr(struct dentry * dentry, struct iattr * iattr)
> {
> struct inode * inode = dentry->d_inode;
>
I don't see why this shouldn't or can't be made static. I'll ACK it and
then you guys can deal with it however you like.
-Dave
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH resend] sysfs: mark a locally-only used function static
2009-10-13 14:42 ` David P. Quigley
@ 2009-10-14 18:47 ` Stefan Richter
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Richter @ 2009-10-14 18:47 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: James Morris, Stephen D. Smalley, linux-kernel, David P. Quigley
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Acked-by: David P. Quigley <dpquigl@tycho.nsa.gov>
---
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c
index e28cecf..e144351 100644
--- a/fs/sysfs/inode.c
+++ b/fs/sysfs/inode.c
@@ -46,7 +46,7 @@ int __init sysfs_inode_init(void)
return bdi_init(&sysfs_backing_dev_info);
}
-struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
+static struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
{
struct sysfs_inode_attrs *attrs;
struct iattr *iattrs;
@@ -64,6 +64,7 @@ struct sysfs_inode_attrs *sysfs_init_inode_attrs(struct sysfs_dirent *sd)
return attrs;
}
+
int sysfs_setattr(struct dentry * dentry, struct iattr * iattr)
{
struct inode * inode = dentry->d_inode;
--
Stefan Richter
-=====-==--= =-=- -===-
http://arcgraph.de/sr/
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-10-14 18:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-11 1:02 [PATCH] sysfs: mark a locally-only used function static Stefan Richter
2009-10-11 4:42 ` Greg KH
2009-10-11 7:52 ` Stefan Richter
2009-10-12 22:10 ` Greg KH
2009-10-13 14:42 ` David P. Quigley
2009-10-14 18:47 ` [PATCH resend] " Stefan Richter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox