Re: [PATCH 5/5] PCI: fix memory leak in aer_inject

Huang Ying
2009-10-27T00:43:20Z

Hi, Jesse,

On Tue, 2009-10-27 at 05:21 +0800, Jesse Barnes wrote:
> On Mon, 12 Oct 2009 15:44:30 +0800
> Huang Ying <ying.huang@intel.com> wrote:
>
> > On Mon, 2009-10-12 at 15:03 +0800, Andrew Patterson wrote:
> > > PCI: fix memory leak in aer_inject
> > >
> > > Fixed probable typo in aer_inject cleanup code resulting in a memory
> > > leak.
> > >
> > > Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
> > > ---
> > >
> > > diff --git a/drivers/pci/pcie/aer/aer_inject.c
> > > b/drivers/pci/pcie/aer/aer_inject.c index da2ad6e..2246bf7 100644
> > > --- a/drivers/pci/pcie/aer/aer_inject.c
> > > +++ b/drivers/pci/pcie/aer/aer_inject.c
> > > @@ -474,7 +474,7 @@ static void __exit aer_inject_exit(void)
> > > }
> > >
> > > spin_lock_irqsave(&inject_lock, flags);
> > > - list_for_each_entry_safe(err, err_next, &pci_bus_ops_list,
> > > list) {
> > > + list_for_each_entry_safe(err, err_next, &einjected, list) {
> > > list_del(&err->list);
> > > kfree(err);
> > > }
> >
> > Thanks for the patch.
> >
> > Acked-by: Huang Ying <ying.huang@intel.com>
> >
>
> How do the rest of the patches look, Ying? Should I add your acked-by
> on Andrew's latest set?

The whole latest patchset looks good to me.

Acked-by: Huang Ying <ying.huang@intel.com>

Best Regards,
Huang Ying