From: Ingo Molnar <mingo@elte.hu>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg KH <gregkh@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [crash] NULL pointer dereference at IP: [<ffffffff812e9ccb>] uart_close+0x2a/0x1e4
Date: Mon, 12 Oct 2009 14:22:45 +0200 [thread overview]
Message-ID: <20091012122245.GA22088@elte.hu> (raw)
In-Reply-To: <20091012115549.GA13987@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> > so uart_close takes the wrong lock. I've checked the rest of the
> > patch for the same error and I don't see any other screwups.
>
> Cool! This very much looks like something that could fix both problems.
> I've started testing your fix.
Unfortunately it does not solve the problem, i still get:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000240
IP: [<ffffffff812ea215>] uart_close+0x24/0x1e5
PGD 77166067 PUD 77171067 PMD 0
Oops: 0000 [#1] DEBUG_PAGEALLOC
last sysfs file:
CPU 0
Modules linked in:
Pid: 1107, comm: hwclock Not tainted 2.6.32-rc4-tip #8185 System Product Name
RIP: 0010:[<ffffffff812ea215>] [<ffffffff812ea215>] uart_close+0x24/0x1e5
RSP: 0018:ffff8800770e9b98 EFLAGS: 00010246
RAX: ffffffff812ea1f1 RBX: ffff88007df80000 RCX: 0000000000000000
RDX: ffff88007aaa7900 RSI: ffff88007df80000 RDI: ffff88007b3eb000
RBP: ffff8800770e9bb8 R08: ffff88007a62cd80 R09: ffff88007a62c600
R10: 0000000000000246 R11: ffffffff812c1ed9 R12: 0000000000000000
R13: ffff88007b3eb000 R14: 0000000000000000 R15: 0000000000000000
FS: 00007fc1bae596f0(0000) GS:ffffffff81b38000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 0000000000000240 CR3: 0000000077187000 CR4: 00000000000026f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process hwclock (pid: 1107, threadinfo ffff8800770e8000, task ffff88007a62c600)
Stack:
ffff88007b3eb000 0000000000000000 00000000fffffffa 0000000000000000
<0> ffff8800770e9c98 ffffffff812c3ece ffff8800770e9bf8 0000000000000246
<0> ffff88007aab8150 ffff88007aab8000 ffff88007b3eb000 ffffffff81d57560
Call Trace:
[<ffffffff812c3ece>] tty_release_dev+0x1ca/0x4d8
[<ffffffff81772e4e>] ? mutex_unlock+0xe/0x10
[<ffffffff81774cc5>] ? _spin_unlock+0x2b/0x2f
[<ffffffff812c478d>] tty_open+0x33f/0x41d
[<ffffffff811174a1>] chrdev_open+0x179/0x19a
[<ffffffff81112a8a>] __dentry_open+0x1cf/0x2f9
[<ffffffff81117328>] ? chrdev_open+0x0/0x19a
[<ffffffff81113a14>] nameidata_to_filp+0x45/0x56
[<ffffffff8112035a>] do_filp_open+0x58a/0xa39
[<ffffffff8103f3ce>] ? native_sched_clock+0x3b/0x52
[<ffffffff8103f38f>] ? sched_clock+0x17/0x1b
[<ffffffff8108c06e>] ? cpu_clock+0x41/0x5b
[<ffffffff8112971c>] ? alloc_fd+0x110/0x11f
[<ffffffff81774cc5>] ? _spin_unlock+0x2b/0x2f
[<ffffffff8112971c>] ? alloc_fd+0x110/0x11f
[<ffffffff811127c8>] do_sys_open+0x62/0x109
[<ffffffff811128a2>] sys_open+0x20/0x22
[<ffffffff81038dff>] system_call_fastpath+0x16/0x1b
Code: 5d 41 5e 41 5f c9 c3 55 48 89 e5 41 56 41 55 41 54 53 0f 1f 44 00 00 f6 05 53 29 55 01 08 4c 8b a7 28 04 00 00 49 89 fd 48 89 f3 <4d> 8b b4 24 40 02 00 00 74 16 f6 05 3c 29 55 01 40 74 0d 80 3d
RIP [<ffffffff812ea215>] uart_close+0x24/0x1e5
RSP <ffff8800770e9b98>
CR2: 0000000000000240
---[ end trace a06c2589766a51bf ]---
I still think it's a break-through - you found one bug in the patch
already, which means that there could be more in there ;-)
Ingo
next prev parent reply other threads:[~2009-10-12 12:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 21:58 Linux 2.6.32-rc4 Linus Torvalds
2009-10-12 7:42 ` [origin tree build failure] [PATCH] Revert "USB: musb: make HAVE_CLK support optional" Ingo Molnar
2009-10-12 13:05 ` Mike Frysinger
2009-10-12 14:29 ` Greg KH
2009-10-12 14:39 ` Mike Frysinger
2009-10-12 15:00 ` Ingo Molnar
2009-10-12 15:09 ` Mike Frysinger
2009-10-12 13:49 ` [PATCH] USB: musb: invert arch depend string Mike Frysinger
2009-10-12 14:28 ` Greg KH
2009-10-12 15:02 ` Ingo Molnar
2009-10-12 8:05 ` [crash] NULL pointer dereference at IP: [<ffffffff812e9ccb>] uart_close+0x2a/0x1e4 Ingo Molnar
2009-10-12 9:19 ` Ingo Molnar
2009-10-12 9:27 ` Ingo Molnar
2009-10-12 11:25 ` Ingo Molnar
2009-10-12 11:45 ` Alan Cox
2009-10-12 11:55 ` Ingo Molnar
2009-10-12 12:22 ` Ingo Molnar [this message]
2009-10-12 13:06 ` Alan Cox
2009-10-12 14:23 ` Ingo Molnar
2009-10-12 16:19 ` Linus Torvalds
2009-10-12 16:26 ` Ingo Molnar
2009-10-12 16:28 ` Ingo Molnar
2009-10-12 16:37 ` Linus Torvalds
2009-10-12 17:13 ` [PATCH] tty, serial: Fix race and NULL check in uart_close() Ingo Molnar
2009-10-12 8:29 ` Linux 2.6.32-rc4 Ingo Molnar
2009-10-12 8:30 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/pci/hotplug/cpqphp.h Ingo Molnar
2009-10-12 8:32 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/char/rtc.c Ingo Molnar
2009-10-12 8:40 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/net/wan/pci200syn.c Ingo Molnar
2009-10-12 9:11 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/net/wan/n2.c Ingo Molnar
2009-10-12 9:16 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/net/wan/c101.c Ingo Molnar
2009-10-12 10:06 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/char/genrtc.c Ingo Molnar
2009-10-12 13:29 ` Linux 2.6.32-rc4 Alexey Dobriyan
2009-10-12 9:43 ` Ingo Molnar
2009-10-12 13:34 ` Alexey Dobriyan
2009-10-12 9:48 ` Ingo Molnar
2009-10-12 14:22 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/char/sonypi.c Ingo Molnar
2009-10-12 13:01 ` Linux 2.6.32-rc4 Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012122245.GA22088@elte.hu \
--to=mingo@elte.hu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox