From: Ingo Molnar <mingo@elte.hu>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: Greg KH <gregkh@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [origin tree build failure] [PATCH] Revert "USB: musb: make HAVE_CLK support optional"
Date: Mon, 12 Oct 2009 17:00:37 +0200 [thread overview]
Message-ID: <20091012150037.GA14004@elte.hu> (raw)
In-Reply-To: <8bd0f97a0910120739k3122bctb46713881eaef9ca@mail.gmail.com>
* Mike Frysinger <vapier.adi@gmail.com> wrote:
> On Mon, Oct 12, 2009 at 10:29, Greg KH wrote:
> > On Mon, Oct 12, 2009 at 09:05:57AM -0400, Mike Frysinger wrote:
> >> On Mon, Oct 12, 2009 at 03:42, Ingo Molnar wrote:
> >> >
> >> > * Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >> >
> >> >> As usual, please test this for regressions, both new and old.
> >> >
> >> >> USB: musb: make HAVE_CLK support optional
> >> >
> >> > This USB/Blackfin commit broke the x86 build with these config options:
> >> >
> >> > CONFIG_USB_MUSB_HDRC=y
> >> > CONFIG_USB_MUSB_HOST=y
> >> > # CONFIG_USB_MUSB_PERIPHERAL is not set
> >> > # CONFIG_USB_MUSB_OTG is not set
> >> > # CONFIG_USB_GADGET_MUSB_HDRC is not set
> >> > CONFIG_USB_MUSB_HDRC_HCD=y
> >> > CONFIG_MUSB_PIO_ONLY=y
> >> > CONFIG_USB_MUSB_DEBUG=y
> >> >
> >> > Because a side-effect of the patch was that it enabled the driver on x86
> >> > too which doesnt have HAVE_CLK. So this formerly embedded-only driver
> >> > got exposed on the more widely tested x86 platform.
> >>
> >> this is dumb. you're addressing unrealistic scenarios (randconfig) by
> >> reverting code for realistic scenarios. how about updating the
> >> already present arch depend string instead.
> >
> > We want 'randconfig' to work, so this is not unrealistic. Have you not
> > seen Randy Dunlap's zillion patches to get this to all work properly
> > over the past months?
>
> i'm not suggesting it not be fixed, i'm suggested it be *fixed*
> instead of blindly reverted.
Sure, i'd agree with that if we were in the merge window. The thing is,
-rc4 is not the time to do patches that need fixes. It is to fix
regressions. I dont think this commit applies as a regression fix, does
it? It _introduces_ a regression.
So a revert is a proper first-level response to this and i fail to
understand your surprise about that. A fix is nice too, of course, if
it's simple enough.
Ingo
next prev parent reply other threads:[~2009-10-12 15:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 21:58 Linux 2.6.32-rc4 Linus Torvalds
2009-10-12 7:42 ` [origin tree build failure] [PATCH] Revert "USB: musb: make HAVE_CLK support optional" Ingo Molnar
2009-10-12 13:05 ` Mike Frysinger
2009-10-12 14:29 ` Greg KH
2009-10-12 14:39 ` Mike Frysinger
2009-10-12 15:00 ` Ingo Molnar [this message]
2009-10-12 15:09 ` Mike Frysinger
2009-10-12 13:49 ` [PATCH] USB: musb: invert arch depend string Mike Frysinger
2009-10-12 14:28 ` Greg KH
2009-10-12 15:02 ` Ingo Molnar
2009-10-12 8:05 ` [crash] NULL pointer dereference at IP: [<ffffffff812e9ccb>] uart_close+0x2a/0x1e4 Ingo Molnar
2009-10-12 9:19 ` Ingo Molnar
2009-10-12 9:27 ` Ingo Molnar
2009-10-12 11:25 ` Ingo Molnar
2009-10-12 11:45 ` Alan Cox
2009-10-12 11:55 ` Ingo Molnar
2009-10-12 12:22 ` Ingo Molnar
2009-10-12 13:06 ` Alan Cox
2009-10-12 14:23 ` Ingo Molnar
2009-10-12 16:19 ` Linus Torvalds
2009-10-12 16:26 ` Ingo Molnar
2009-10-12 16:28 ` Ingo Molnar
2009-10-12 16:37 ` Linus Torvalds
2009-10-12 17:13 ` [PATCH] tty, serial: Fix race and NULL check in uart_close() Ingo Molnar
2009-10-12 8:29 ` Linux 2.6.32-rc4 Ingo Molnar
2009-10-12 8:30 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/pci/hotplug/cpqphp.h Ingo Molnar
2009-10-12 8:32 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/char/rtc.c Ingo Molnar
2009-10-12 8:40 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/net/wan/pci200syn.c Ingo Molnar
2009-10-12 9:11 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/net/wan/n2.c Ingo Molnar
2009-10-12 9:16 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/net/wan/c101.c Ingo Molnar
2009-10-12 10:06 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/char/genrtc.c Ingo Molnar
2009-10-12 13:29 ` Linux 2.6.32-rc4 Alexey Dobriyan
2009-10-12 9:43 ` Ingo Molnar
2009-10-12 13:34 ` Alexey Dobriyan
2009-10-12 9:48 ` Ingo Molnar
2009-10-12 14:22 ` [origin tree build failure] [PATCH] headers: Fix build in drivers/char/sonypi.c Ingo Molnar
2009-10-12 13:01 ` Linux 2.6.32-rc4 Thomas Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012150037.GA14004@elte.hu \
--to=mingo@elte.hu \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox