From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Eric Sesterhenn <eric.sesterhenn@lsexperts.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Fix leak in usermode linux
Date: Tue, 13 Oct 2009 00:10:58 +0800 [thread overview]
Message-ID: <20091012161058.GB3961@hack> (raw)
In-Reply-To: <4AD32A14.3050408@lsexperts.de>
On Mon, Oct 12, 2009 at 03:07:32PM +0200, Eric Sesterhenn wrote:
>hi,
>
>this was spotted by cppcheck, if find_tempdir fails,
>we dont free tempname.
>
>Signed-off-by: Eric Sesterhenn <eric.sesterhenn@lsexperts.de>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
Thanks!
>
>--- linux/arch/um/os-Linux/mem.c.orig 2009-10-12 15:04:28.000000000 +0200
>+++ linux/arch/um/os-Linux/mem.c 2009-10-12 15:04:37.000000000 +0200
>@@ -175,7 +175,7 @@ static int __init make_tempfile(const ch
>
> find_tempdir();
> if ((tempdir == NULL) || (strlen(tempdir) >= MAXPATHLEN))
>- return -1;
>+ goto out;
>
> if (template[0] != '/')
> strcpy(tempname, tempdir);
>
>--
>LSE Leading Security Experts GmbH, Postfach 100121, 64201 Darmstadt
>Unternehmenssitz: Weiterstadt, Amtsgericht Darmstadt: HRB8649
>Geschäftsführer: Oliver Michel, Sven Walther
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Live like a child, think like the god.
prev parent reply other threads:[~2009-10-12 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 13:07 [Patch] Fix leak in usermode linux Eric Sesterhenn
2009-10-12 16:10 ` Américo Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012161058.GB3961@hack \
--to=xiyou.wangcong@gmail.com \
--cc=eric.sesterhenn@lsexperts.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox