From: Greg KH <greg@kroah.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Hank Janssen <hjanssen@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tom Hanrahan <hanrahat@microsoft.com>,
Hashir Abdi <habdi@microsoft.com>
Subject: Re: [patch] Staging: hv: Fix vmbus load hang caused by wrong data packing
Date: Mon, 12 Oct 2009 13:34:07 -0700 [thread overview]
Message-ID: <20091012203407.GA30839@kroah.com> (raw)
In-Reply-To: <1FB5E1D5CA062146B38059374562DF7212DEE3EC@TK5EX14MBXC130.redmond.corp.microsoft.com>
On Sat, Oct 10, 2009 at 11:16:00PM +0000, Haiyang Zhang wrote:
> From: Haiyang Zhang <haiyangz@microsoft.com>
>
> Fix vmbus load hang caused by wrong data packing.
I also note that you are packing more structures here with this patch
than the code before the patch had. Could that be the issue here? The
additional structures are ones that should be packed instead?
If so, that might explain why things are working, just try to add the
packed attribute to the struct vmbus_channel and struct
vmbus_channel_debug_info and struct vmbus_channel_msginfo structures.
Although, if that solves the problem, then something else is seriously
wrong, as those structures should not being passed across the hypervisor
boundry...
thanks,
greg k-h
next prev parent reply other threads:[~2009-10-12 20:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 23:16 [patch] Staging: hv: Fix vmbus load hang caused by wrong data packing Haiyang Zhang
2009-10-12 15:30 ` Greg KH
2009-10-12 17:03 ` Haiyang Zhang
2009-10-12 17:29 ` Greg KH
2009-10-12 20:10 ` Hank Janssen
2009-10-12 20:22 ` Greg KH
2009-10-12 20:44 ` Haiyang Zhang
2009-10-12 21:27 ` Greg KH
2009-10-12 23:41 ` Haiyang Zhang
2009-10-13 5:08 ` Pekka Enberg
2009-10-16 20:03 ` Hank Janssen
2009-10-12 20:34 ` Greg KH [this message]
2009-10-16 20:11 ` [PATCH 1/1] Staging: hv: Fix vmbus load hang caused by faulty " Hank Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012203407.GA30839@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=habdi@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hanrahat@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox