From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [regressions] Re: kbuild: save ARCH & CROSS_COMPILE when building a kernel
Date: Mon, 12 Oct 2009 22:44:02 +0200 [thread overview]
Message-ID: <20091012204402.GC17163@elte.hu> (raw)
In-Reply-To: <20091011213546.GB2768@merkur.ravnborg.org>
* Sam Ravnborg <sam@ravnborg.org> wrote:
> On Fri, Oct 09, 2009 at 11:26:48AM +0200, Ingo Molnar wrote:
> >
> > * Sam Ravnborg <sam@ravnborg.org> wrote:
> >
> > > On Sat, Oct 03, 2009 at 12:34:41PM +0200, Ingo Molnar wrote:
> > > >
> > > > Sam,
> > > >
> > > > that arch-cache thing introduced in:
> > > >
> > > > 5755433: kbuild: save ARCH & CROSS_COMPILE when building a kernel
> > > >
> > > > isnt working very well in my experience.
> > > >
> > > > 1) it's a nuisance in cross-builds (it broke several cross-build scripts
> > > > of mine)
> > >
> > > On the contrary it has helped me big time on my cross builds. [...]
> >
> > Could you please try to do that without hurting the existing scripting
> > and existing workflow of other people?
>
> The only message in the above was that this was also beneficial
> to some - and not a nusiance only.
>
> >
> > > No need to script is all to remember to set the correct ARCH +
> > > CROSS_COMPILE settings.
> >
> > Then put your new state into the .config instead of this stupid
> > include/generated/ extra state that is a _big_ regression over v2.6.31
> > in terms of cross-build usability.
>
> I cannot see why saving this in include/generated/*
> has anything to do with your complains. I guess you did not look
> at the patch in question.
>
> What is hurting you and several other users are _not_ related
> to the fact that we save ARCH and CROSS_COMPILE setting or where
> we save it.
> What hurt you is the consistency checks that was added
> to try to catch people in doing something unexpected.
>
> Unexpected like trying to build a 64 bit kernel where they
> previosuly were building a 32 bit kernel.
> Or when they suddenly used a different set of binutils
> because they changed CROSS_COMPILE settings.
>
>
> The patch in question is reverted in my next push to Linus.
Thanks! Mind sending the fix/revert here too, so that we can test
whether that resolves all the problems?
Ingo
next prev parent reply other threads:[~2009-10-12 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-03 10:34 [regressions] Re: kbuild: save ARCH & CROSS_COMPILE when building a kernel Ingo Molnar
2009-10-04 19:17 ` Sam Ravnborg
2009-10-09 9:26 ` Ingo Molnar
2009-10-11 21:35 ` Sam Ravnborg
2009-10-12 20:44 ` Ingo Molnar [this message]
2009-10-12 21:08 ` Sam Ravnborg
2009-10-12 21:12 ` Ingo Molnar
2009-10-09 8:58 ` Peter Zijlstra
2009-10-09 9:23 ` Ingo Molnar
2009-10-09 11:41 ` Peter Zijlstra
2009-10-11 9:05 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091012204402.GC17163@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox