From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: herbert@gondor.apana.org.au, rjw@sisk.pl,
Ralf.Hildebrandt@charite.de, linux-kernel@vger.kernel.org,
kernel-testers@vger.kernel.org, netdev@vger.kernel.org,
yjwei@cn.fujitsu.com, tyasui@redhat.com, haoki@redhat.com
Subject: Re: [PATCH] udp: Fix udp_poll() and ioctl()
Date: Tue, 13 Oct 2009 03:18:14 -0700 (PDT) [thread overview]
Message-ID: <20091013.031814.100807531.davem@davemloft.net> (raw)
In-Reply-To: <4ACF4C1C.4050505@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 09 Oct 2009 16:43:40 +0200
> [PATCH] udp: Fix udp_poll()
>
> udp_poll() can in some circumstances drop frames with incorrect checksums.
>
> Problem is we now have to lock the socket while dropping frames, or risk
> sk_forward corruption.
>
> This bug is present since commit 95766fff6b9a78d1
> ([UDP]: Add memory accounting.)
>
> While we are at it, we can correct ioctl(SIOCINQ) to also drop bad frames.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Looks good, applied, thanks Eric!
prev parent reply other threads:[~2009-10-13 10:18 UTC|newest]
Thread overview: 188+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 19:53 2.6.32-rc1-git2: Reported regressions 2.6.30 -> 2.6.31 Rafael J. Wysocki
2009-10-01 19:53 ` [Bug #13645] NULL pointer dereference at (null) (level2_spare_pgt) Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13836] suspend script fails, related to stdout? Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13733] 2.6.31-rc2: irq 16: nobody cared Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13809] oprofile: possible circular locking dependency detected Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13940] iwlagn and sky2 stopped working, ACPI-related Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13906] Huawei E169 GPRS connection causes Ooops Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13935] 2.6.31-rcX breaks Apple MightyMouse (Bluetooth version) Rafael J. Wysocki
2009-10-02 12:51 ` Jan Scholz
2009-10-02 15:58 ` Jiri Kosina
2009-10-02 17:16 ` Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13869] Radeon framebuffer (w/o KMS) corruption at boot Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13942] Troubles with AoE and uninitialized object Rafael J. Wysocki
2009-10-02 19:36 ` Bruno Prémont
2009-10-02 21:24 ` Rafael J. Wysocki
2009-10-02 19:57 ` David Rientjes
2009-10-01 19:55 ` [Bug #13941] x86 Geode issue Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13948] ath5k broken after suspend-to-ram Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13943] WARNING: at net/mac80211/mlme.c:2292 with ath5k Rafael J. Wysocki
2009-10-02 7:12 ` Fabio Comolli
2009-10-02 17:17 ` Rafael J. Wysocki
2009-10-02 21:37 ` Fabio Comolli
2009-10-02 21:42 ` Rafael J. Wysocki
2009-10-03 13:36 ` Fabio Comolli
2009-10-01 19:55 ` [Bug #14013] hd don't show up Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13950] Oops when USB Serial disconnected while in use Rafael J. Wysocki
2009-10-02 19:45 ` Bruno Prémont
2009-10-02 21:26 ` Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #13987] Received NMI interrupt at resume Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14017] _end symbol missing from Symbol.map Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14070] lockdep warning triggered by dup_fd Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14058] Oops in fsnotify Rafael J. Wysocki
2009-10-02 7:14 ` Jaswinder Singh Rajput
2009-10-01 19:55 ` [Bug #14090] WARNING: at fs/notify/inotify/inotify_user.c:394 Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14133] WARNING: at arch/x86/kernel/smp.c:117 native_smp_send_reschedule Rafael J. Wysocki
2009-10-02 7:00 ` Jaswinder Singh Rajput
2009-10-02 7:34 ` Jens Axboe
2009-10-02 17:21 ` Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14137] usb console regressions Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14114] Tuning a saa7134 based card is broken in kernel 2.6.31-rc7 Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14141] order 2 page allocation failures in iwlagn Rafael J. Wysocki
2009-10-02 9:11 ` Frans Pop
2009-10-02 9:32 ` Mel Gorman
2009-10-02 10:01 ` Frans Pop
2009-10-02 20:01 ` Karol Lewandowski
2009-10-04 19:28 ` Karol Lewandowski
2009-10-05 5:13 ` Frans Pop
2009-10-05 6:50 ` Frans Pop
2009-10-05 8:54 ` Frans Pop
2009-10-05 8:57 ` Mel Gorman
2009-10-05 21:34 ` Frans Pop
2009-10-06 0:04 ` David Rientjes
2009-10-06 1:25 ` KOSAKI Motohiro
2009-10-06 8:53 ` Mel Gorman
2009-10-06 9:14 ` David Rientjes
2009-10-06 9:22 ` Mel Gorman
2009-10-06 10:23 ` Frans Pop
2009-10-11 23:10 ` Frans Pop
2009-10-11 23:36 ` Frans Pop
2009-10-12 13:43 ` Mel Gorman
2009-10-12 17:32 ` Frans Pop
2009-10-12 18:43 ` Mel Gorman
2009-10-13 20:38 ` Frans Pop
2009-10-14 10:30 ` Mel Gorman
2009-10-14 13:10 ` Frans Pop
2009-10-14 15:40 ` Mel Gorman
2009-10-14 16:13 ` Frans Pop
2009-10-14 18:34 ` Frans Pop
2009-10-14 23:56 ` Mel Gorman
2009-10-15 20:15 ` Frans Pop
2009-10-16 9:39 ` Mel Gorman
2009-10-14 16:30 ` reinette chatre
2009-10-18 23:33 ` Frans Pop
2009-10-19 0:36 ` Pekka Enberg
2009-10-19 2:44 ` Frans Pop
2009-10-19 9:49 ` [Bug #14141] order 2 page allocation failures (generic) Tobi Oetiker
2009-10-19 9:54 ` Pekka Enberg
2009-10-19 14:01 ` Karol Lewandowski
2009-10-19 14:06 ` Mel Gorman
2009-10-19 17:09 ` Karol Lewandowski
2009-10-20 1:47 ` Karol Lewandowski
2009-10-19 13:31 ` Mel Gorman
2009-10-19 13:40 ` Tobias Oetiker
2009-10-19 14:09 ` Mel Gorman
2009-10-19 14:16 ` Tobias Oetiker
2009-10-19 14:59 ` Mel Gorman
2009-10-19 20:12 ` Tobias Oetiker
2009-10-19 20:17 ` Tobias Oetiker
2009-10-20 10:57 ` Mel Gorman
2009-10-20 11:44 ` Tobias Oetiker
2009-10-20 12:51 ` Mel Gorman
2009-10-20 12:58 ` Tobias Oetiker
2009-10-20 13:39 ` Mel Gorman
2009-10-20 13:50 ` Tobias Oetiker
2009-10-20 14:14 ` Mel Gorman
2009-10-20 14:20 ` Tobias Oetiker
2009-10-22 10:27 ` Tobias Oetiker
2009-10-19 2:52 ` [Bug #14141] order 2 page allocation failures in iwlagn Jens Axboe
2009-10-19 14:01 ` Mel Gorman
2009-10-19 16:18 ` Chris Mason
2009-10-19 17:01 ` Christoph Hellwig
2009-10-19 21:57 ` Chris Mason
2009-10-20 10:48 ` Mel Gorman
2009-10-26 21:06 ` Frans Pop
2009-10-27 14:54 ` Mel Gorman
2009-10-27 15:16 ` KOSAKI Motohiro
2009-10-27 15:21 ` Mel Gorman
2009-10-27 15:52 ` Mel Gorman
2009-10-27 16:03 ` Chris Mason
2009-10-27 17:21 ` Frans Pop
2009-11-05 20:14 ` Frans Pop
2009-11-06 9:51 ` Frans Pop
2009-11-09 19:00 ` Mel Gorman
2009-10-25 18:54 ` Frans Pop
2009-10-14 16:28 ` reinette chatre
2009-10-14 16:50 ` Mel Gorman
2009-10-14 20:41 ` reinette chatre
2009-10-14 21:33 ` Frans Pop
2009-10-14 21:55 ` reinette chatre
2009-10-15 2:02 ` Frans Pop
2009-10-15 15:29 ` reinette chatre
2009-10-15 19:41 ` Frans Pop
2009-10-16 17:21 ` reinette chatre
2009-10-17 5:42 ` reinette chatre
2009-10-27 11:10 ` Frans Pop
2009-10-27 16:15 ` reinette chatre
2009-10-01 19:55 ` [Bug #14181] b43 causes panic at system shutdown Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14143] OOPS when setting nr_requests for md devices Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14157] end_request: I/O error, dev cciss/cXdX, sector 0 Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14185] Oops in driversbasefirmware_class Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14204] MCE prevent booting on my computer(pentium iii @500Mhz) Rafael J. Wysocki
2009-10-01 19:55 ` [Bug #14205] Intel DX58SO mainboard - powering off takes really long Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14249] BUG: oops in gss_validate on 2.6.31 Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14222] Hibernation oopses for the 2nd time with 2.6.31 (won't fit the screen) Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14248] 2.6.31 wireless: WARNING: at net/wireless/ibss.c:34 Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14254] Hibernation broken by clocksource: Save mult_orig in clocksource_disable() Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14253] Oops in driversbasefirmware_class Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14251] 2.6.31: no login prompt Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14252] WARNING: at include/linux/skbuff.h:1382 w/ e1000 Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14257] Not able to boot on 32 bit System Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14255] WARNING: at drivers/char/tty_io.c:1267 Rafael J. Wysocki
2009-10-02 0:05 ` Linus Torvalds
2009-10-01 19:56 ` [Bug #14258] Memory leak in SCSI initialization Rafael J. Wysocki
2009-10-02 12:58 ` Tetsuo Handa
2009-10-02 17:26 ` Rafael J. Wysocki
2009-10-07 14:04 ` Tetsuo Handa
2009-10-07 20:24 ` Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14256] kernel BUG at fs/ext3/super.c:435 Rafael J. Wysocki
2009-10-04 17:38 ` Mikael Pettersson
2009-10-04 20:49 ` Rafael J. Wysocki
2009-10-04 23:04 ` Mikael Pettersson
2009-10-09 16:40 ` Mikael Pettersson
2009-10-09 22:03 ` Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14261] e1000e jumbo frames no longer work: 'Unsupported MTU setting' Rafael J. Wysocki
2009-10-02 20:33 ` Nix
2009-10-02 21:31 ` Rafael J. Wysocki
2009-10-02 22:13 ` Jeff Kirsher
2009-10-07 18:34 ` Theodore Tso
2009-10-07 19:12 ` Jeff Kirsher
2009-10-01 19:56 ` [Bug #14264] ehci problem - mouse dead on scroll Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14267] Disassociating atheros wlan Rafael J. Wysocki
2009-10-05 0:34 ` Justin Mattock
2009-10-05 20:09 ` Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14266] regression in page writeback Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14270] Cannot boot on a PIII Celeron Rafael J. Wysocki
2009-10-02 8:30 ` Cyrill Gorcunov
2009-10-02 9:13 ` Michael Tokarev
2009-10-02 10:38 ` Michael Tokarev
2009-10-02 10:55 ` Cyrill Gorcunov
2009-10-02 10:59 ` Michael Tokarev
2009-10-02 14:05 ` Cyrill Gorcunov
2009-10-04 12:14 ` Michael Tokarev
2009-10-04 12:43 ` Cyrill Gorcunov
2009-10-01 19:56 ` [Bug #14265] ifconfig: page allocation failure. order:5, mode:0x8020 w/ e100 Rafael J. Wysocki
2009-10-21 20:04 ` [PATCH] SLUB: Don't drop __GFP_NOFAIL completely from allocate_slab() (was: Re: [Bug #14265] ifconfig: page allocation failure. order:5,ode:0x8020 w/ e100) Karol Lewandowski
2009-10-21 21:06 ` David Rientjes
2009-10-21 21:20 ` Karol Lewandowski
2009-10-22 10:20 ` Mel Gorman
2009-10-22 21:33 ` Karol Lewandowski
2009-10-01 19:56 ` [Bug #14275] kernel>=2.6.31: ahci.c: do not force unconditionally sb600 to 32bit dma any more? Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14294] kernel BUG at drivers/ide/ide-disk.c:187 Rafael J. Wysocki
2009-10-01 19:56 ` [Bug #14301] WARNING: at net/ipv4/af_inet.c:154 Rafael J. Wysocki
2009-10-03 8:36 ` Eric Dumazet
2009-10-03 8:52 ` Eric Dumazet
2009-10-03 17:53 ` Eric Dumazet
2009-10-07 15:41 ` Eric Dumazet
2009-10-09 14:43 ` [PATCH] udp: Fix udp_poll() and ioctl() Eric Dumazet
2009-10-13 10:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013.031814.100807531.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ralf.Hildebrandt@charite.de \
--cc=eric.dumazet@gmail.com \
--cc=haoki@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tyasui@redhat.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).