public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: suspend tree build failure
Date: Tue, 13 Oct 2009 00:44:12 +0200	[thread overview]
Message-ID: <200910130044.12494.rjw@sisk.pl> (raw)
In-Reply-To: <20091012140002.10f1f3d1.sfr@canb.auug.org.au>

On Monday 12 October 2009, Stephen Rothwell wrote:
> Hi Rafael,
> 
> Today's linux-next build (x86_64 allmodconfig) failed like this:
> 
> drivers/base/power/main.c: In function 'device_pm_wait':
> drivers/base/power/main.c:218: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function)
> drivers/base/power/main.c:218: error: (Each undeclared identifier is reported only once
> drivers/base/power/main.c:218: error: for each function it appears in.)
> drivers/base/power/main.c:218: error: implicit declaration of function 'schedule'
> drivers/base/power/main.c: In function 'dbg_show_time':
> drivers/base/power/main.c:514: error: implicit declaration of function 'task_pid_nr'
> drivers/base/power/main.c: In function '__device_resume_noirq':
> drivers/base/power/main.c:551: error: 'TASK_NORMAL' undeclared (first use in this function)
> drivers/base/power/main.c: In function '__device_resume':
> drivers/base/power/main.c:713: error: 'TASK_NORMAL' undeclared (first use in this function)
> drivers/base/power/main.c: In function '__device_suspend_noirq':
> drivers/base/power/main.c:970: error: 'TASK_NORMAL' undeclared (first use in this function)
> drivers/base/power/main.c: In function '__device_suspend':
> drivers/base/power/main.c:1145: error: 'TASK_NORMAL' undeclared (first use in this function)
> 
> Presumably caused by commit d43c36dc6b357fa1806800f18aa30123c747a6d1
> ("headers: remove sched.h from interrupt.h") from Linus' tree.
> 
> I have added the following patch for today.
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 12 Oct 2009 13:48:27 +1100
> Subject: [PATCH] suspend: using TASK_ macros requires sched.h

Thanks Stephen, I added your patch below to the suspend-2.6 tree.

> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/base/power/main.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index 3b09009..fb1c648 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -29,6 +29,7 @@
>  #include <linux/async.h>
>  #include <linux/completion.h>
>  #include <linux/time.h>
> +#include <linux/sched.h>
>  
>  #include "../base.h"
>  #include "power.h"

Best,
Rafael

  reply	other threads:[~2009-10-12 22:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12  3:00 linux-next: suspend tree build failure Stephen Rothwell
2009-10-12 22:44 ` Rafael J. Wysocki [this message]
2009-10-13  0:58   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2009-10-08  4:30 Stephen Rothwell
2009-10-06  2:55 Stephen Rothwell
2009-10-06 22:31 ` Rafael J. Wysocki
2009-10-07  4:29   ` Stephen Rothwell
2009-10-07 20:41     ` Rafael J. Wysocki
2009-10-07 23:48       ` Stephen Rothwell
2009-10-05  5:00 Stephen Rothwell
2009-10-05 23:55 ` Rafael J. Wysocki
2009-10-06  2:39   ` Stephen Rothwell
2009-08-18  8:30 Stephen Rothwell
2009-08-18 21:43 ` Rafael J. Wysocki
2009-08-18 22:13   ` Paul Mundt
2009-08-18 22:40     ` Rafael J. Wysocki
2009-08-18 22:47       ` Paul Mundt
2009-08-18 23:57   ` Stephen Rothwell
2009-08-17  8:40 Stephen Rothwell
2009-08-17 12:06 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910130044.12494.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox