public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Oren Laadan <orenl@cs.columbia.edu>,
	serue@us.ibm.com, "Eric W. Biederman" <ebiederm@xmission.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Pavel Emelyanov <xemul@openvz.org>, Andrew Morton <akpm@osdl.org>,
	torvalds@linux-foundation.org, mikew@google.com, mingo@elte.hu,
	hpa@zytor.com, Nathan Lynch <nathanl@austin.ibm.com>,
	arnd@arndb.de, peterz@infradead.org, Louis.Rilling@kerlabs.com,
	roland@redhat.com, kosaki.motohiro@jp.fujitsu.com,
	randy.dunlap@oracle.com, linux-api@vger.kernel.org,
	Containers <containers@lists.linux-foundation.org>,
	sukadev@us.ibm.com
Subject: [RFC][v8][PATCH 5/10]: Add target_pids parameter to alloc_pid()
Date: Mon, 12 Oct 2009 21:51:42 -0700	[thread overview]
Message-ID: <20091013045142.GE28435@us.ibm.com> (raw)
In-Reply-To: <20091013044925.GA28181@us.ibm.com>



Subject: [RFC][v8][PATCH 5/10]: Add target_pids parameter to alloc_pid()

This parameter is currently NULL, but will be used in a follow-on patch.

Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Reviewed-by: Oren Laadan <orenl@cs.columbia.edu>
---
 include/linux/pid.h |    2 +-
 kernel/fork.c       |    3 ++-
 kernel/pid.c        |    9 +++++++--
 3 files changed, 10 insertions(+), 4 deletions(-)

Index: linux-2.6/include/linux/pid.h
===================================================================
--- linux-2.6.orig/include/linux/pid.h	2009-09-10 10:19:20.000000000 -0700
+++ linux-2.6/include/linux/pid.h	2009-09-10 10:29:10.000000000 -0700
@@ -119,7 +119,7 @@ extern struct pid *find_get_pid(int nr);
 extern struct pid *find_ge_pid(int nr, struct pid_namespace *);
 int next_pidmap(struct pid_namespace *pid_ns, int last);
 
-extern struct pid *alloc_pid(struct pid_namespace *ns);
+extern struct pid *alloc_pid(struct pid_namespace *ns, pid_t *target_pids);
 extern void free_pid(struct pid *pid);
 
 /*
Index: linux-2.6/kernel/fork.c
===================================================================
--- linux-2.6.orig/kernel/fork.c	2009-09-10 10:19:20.000000000 -0700
+++ linux-2.6/kernel/fork.c	2009-09-10 10:29:10.000000000 -0700
@@ -940,6 +940,7 @@ static struct task_struct *copy_process(
 	int retval;
 	struct task_struct *p;
 	int cgroup_callbacks_done = 0;
+	pid_t *target_pids = NULL;
 
 	if ((clone_flags & (CLONE_NEWNS|CLONE_FS)) == (CLONE_NEWNS|CLONE_FS))
 		return ERR_PTR(-EINVAL);
@@ -1110,7 +1111,7 @@ static struct task_struct *copy_process(
 		goto bad_fork_cleanup_io;
 
 	if (pid != &init_struct_pid) {
-		pid = alloc_pid(p->nsproxy->pid_ns);
+		pid = alloc_pid(p->nsproxy->pid_ns, target_pids);
 		if (IS_ERR(pid)) {
 			retval = PTR_ERR(pid);
 			goto bad_fork_cleanup_io;
Index: linux-2.6/kernel/pid.c
===================================================================
--- linux-2.6.orig/kernel/pid.c	2009-09-10 10:23:27.000000000 -0700
+++ linux-2.6/kernel/pid.c	2009-09-10 10:29:10.000000000 -0700
@@ -272,13 +272,14 @@ void free_pid(struct pid *pid)
 	call_rcu(&pid->rcu, delayed_put_pid);
 }
 
-struct pid *alloc_pid(struct pid_namespace *ns)
+struct pid *alloc_pid(struct pid_namespace *ns, pid_t *target_pids)
 {
 	struct pid *pid;
 	enum pid_type type;
 	int i, nr;
 	struct pid_namespace *tmp;
 	struct upid *upid;
+	int tpid;
 
 	pid = kmem_cache_alloc(ns->pid_cachep, GFP_KERNEL);
 	if (!pid) {
@@ -288,7 +289,11 @@ struct pid *alloc_pid(struct pid_namespa
 
 	tmp = ns;
 	for (i = ns->level; i >= 0; i--) {
-		nr = alloc_pidmap(tmp, 0);
+		tpid = 0;
+		if (target_pids)
+			tpid = target_pids[i];
+
+		nr = alloc_pidmap(tmp, tpid);
 		if (nr < 0)
 			goto out_free;
 

  parent reply	other threads:[~2009-10-13  4:51 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13  4:49 [RFC][v8][PATCH 0/10] Implement clone3() system call Sukadev Bhattiprolu
2009-10-13  4:49 ` [RFC][v8][PATCH 1/10]: Factor out code to allocate pidmap page Sukadev Bhattiprolu
2009-10-13  4:50 ` [RFC][v8][PATCH 2/10]: Have alloc_pidmap() return actual error code Sukadev Bhattiprolu
2009-10-13  4:50 ` [RFC][v8][PATCH 3/10]: Make pid_max a pid_ns property Sukadev Bhattiprolu
2009-10-13  5:19   ` Alexey Dobriyan
2009-10-13 13:09   ` Pavel Emelyanov
2009-10-13 15:24     ` Serge E. Hallyn
2009-10-13 16:10       ` Pavel Emelyanov
2009-10-13 16:28         ` Serge E. Hallyn
2009-10-13  4:51 ` [RFC][v8][PATCH 4/10]: Add target_pid parameter to alloc_pidmap() Sukadev Bhattiprolu
2009-10-13 11:50   ` Pavel Emelyanov
2009-10-15  0:24     ` Sukadev Bhattiprolu
2009-10-13  4:51 ` Sukadev Bhattiprolu [this message]
2009-10-13  4:52 ` [RFC][v8][PATCH 6/10]: Add target_pids parameter to copy_process() Sukadev Bhattiprolu
2009-10-13  4:52 ` [RFC][v8][PATCH 7/10]: Check invalid clone flags Sukadev Bhattiprolu
2009-10-13 18:35   ` Oren Laadan
2009-10-13 23:38     ` Sukadev Bhattiprolu
2009-10-13  4:52 ` [RFC][v8][PATCH 8/10]: Define do_fork_with_pids() Sukadev Bhattiprolu
2009-10-13  4:54 ` [RFC][v8][PATCH 9/10]: Define clone3() syscall Sukadev Bhattiprolu
2009-10-13 18:46   ` Oren Laadan
2009-10-16  4:20   ` Sukadev Bhattiprolu
2009-10-16  6:25     ` Michael Kerrisk
2009-10-16 18:06       ` Sukadev Bhattiprolu
2009-10-19 17:44         ` Matt Helsley
2009-10-19 21:31           ` H. Peter Anvin
2009-10-19 23:50             ` Matt Helsley
2009-10-21  4:26               ` Michael Kerrisk
2009-10-21 13:03                 ` H. Peter Anvin
2009-10-21 19:44                   ` Sukadev Bhattiprolu
2009-10-21 22:03                     ` H. Peter Anvin
2009-10-22 10:40                     ` Michael Kerrisk
2009-10-22 18:10                       ` Sukadev Bhattiprolu
2009-10-22 10:26                   ` Michael Kerrisk
2009-10-22 11:38                     ` H. Peter Anvin
2009-10-22 12:14                       ` Michael Kerrisk
2009-10-22 12:19                         ` H. Peter Anvin
2009-10-22 13:57                         ` Matt Helsley
2009-10-13  4:55 ` [RFC][v8][PATCH 10/10]: Document " Sukadev Bhattiprolu
2009-10-14 12:26   ` Arnd Bergmann
2009-10-14 18:39     ` Sukadev Bhattiprolu
2009-10-19 21:36   ` Pavel Machek
2009-10-21  8:37     ` Arnd Bergmann
2009-10-21  9:33       ` Pavel Machek
2009-10-21 13:26         ` Arnd Bergmann
2009-10-21 18:27     ` Sukadev Bhattiprolu
2009-10-13 20:50 ` [RFC][v8][PATCH 0/10] Implement clone3() system call Roland McGrath
2009-10-13 23:27   ` Sukadev Bhattiprolu
2009-10-13 23:53     ` Roland McGrath
2009-10-14  1:13       ` H. Peter Anvin
2009-10-14  4:36         ` Sukadev Bhattiprolu
2009-10-14  4:38           ` H. Peter Anvin
2009-10-14 22:36         ` Sukadev Bhattiprolu
2009-10-14 22:49           ` H. Peter Anvin
2009-10-15  0:17             ` Sukadev Bhattiprolu
2009-10-13 23:49 ` H. Peter Anvin
2009-10-14  1:39   ` Matt Helsley
2009-10-14  2:24     ` H. Peter Anvin
2009-10-14  4:40       ` Sukadev Bhattiprolu
2009-10-14  4:50         ` H. Peter Anvin
2009-10-14 16:07         ` Serge E. Hallyn
2009-10-16 19:22 ` Daniel Lezcano
2009-10-16 19:44   ` Sukadev Bhattiprolu
2009-10-19 20:34     ` Daniel Lezcano
2009-10-19 21:47       ` Oren Laadan
2009-10-20  0:51         ` Matt Helsley
2009-10-20  3:33           ` Eric W. Biederman
2009-10-20  4:03             ` Sukadev Bhattiprolu
2009-10-20 10:46               ` Eric W. Biederman
2009-10-20 14:16                 ` Serge E. Hallyn
2009-10-20 18:33                 ` Sukadev Bhattiprolu
2009-10-20 19:26                   ` Eric W. Biederman
2009-10-20 20:13                     ` Oren Laadan
2009-10-21  6:20                     ` Sukadev Bhattiprolu
2009-10-21  9:16                       ` Eric W. Biederman
2009-10-21 18:52                         ` Sukadev Bhattiprolu
2009-10-21 21:11                           ` Eric W. Biederman
2009-10-23  0:42                         ` Sukadev Bhattiprolu
2009-10-23  1:03                           ` Eric W. Biederman
2009-10-23  5:30                             ` Sukadev Bhattiprolu
2009-10-23  5:44                               ` Eric W. Biederman
2009-10-23 19:21                                 ` Sukadev Bhattiprolu
2009-10-23 20:48                                   ` Sukadev Bhattiprolu
2009-10-23 23:26                                     ` Eric W. Biederman
2009-10-24  3:38                                       ` Sukadev Bhattiprolu
2009-10-23 19:16                               ` Oren Laadan
2009-10-23 19:34                                 ` Oren Laadan
2009-10-23 23:12                                   ` Eric W. Biederman
2009-10-20 14:09             ` Serge E. Hallyn
2009-10-21 15:53         ` Daniel Lezcano
2009-10-21 18:45           ` Oren Laadan
2009-10-22 11:22             ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091013045142.GE28435@us.ibm.com \
    --to=sukadev@linux.vnet.ibm.com \
    --cc=Louis.Rilling@kerlabs.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=arnd@arndb.de \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikew@google.com \
    --cc=mingo@elte.hu \
    --cc=nathanl@austin.ibm.com \
    --cc=orenl@cs.columbia.edu \
    --cc=peterz@infradead.org \
    --cc=randy.dunlap@oracle.com \
    --cc=roland@redhat.com \
    --cc=serue@us.ibm.com \
    --cc=sukadev@us.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox