From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] x86: unify sys_iopl
Date: Tue, 13 Oct 2009 12:30:44 +0200 [thread overview]
Message-ID: <20091013103044.GA3915@elte.hu> (raw)
In-Reply-To: <4ABD3EC2.1020104@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> Hi Ingo,
>
> The x86-64 implementation of iopl was buggy because it never ended up
> calling set_iopl_mask(). This had no effect on native sys_iopl
> (because set_iopl_mask is normally no-op on 64-bit), but it ended up
> never calling the pvop, which caused iopl to have no effect on 64-bit
> Xen guests.
>
> The two functions are needlessly different anyway. This patch just
> unifies them into a single function which is mostly derived from the
> 32-bit version.
>
> Thanks,
> J
>
> The following changes since commit c44c9ec0f38b939b3200436e3aa95c1aa83c41c7:
> Jeremy Fitzhardinge (1):
> x86: split NX setup into separate file to limit unstack-protected code
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git bugfix
>
> Jeremy Fitzhardinge (1):
> x86: unify sys_iopl
>
> arch/x86/include/asm/syscalls.h | 8 +++-----
> arch/x86/kernel/ioport.c | 11 ++---------
> 2 files changed, 5 insertions(+), 14 deletions(-)
Pulled, thanks a lot Jeremy!
It's in tip:x86/paravirt right now. I'm uneasy about pushing this into
.32 - we had this status quo forever. Peter, Thomas, what do you think?
Ingo
next prev parent reply other threads:[~2009-10-13 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 22:05 [GIT PULL] x86: unify sys_iopl Jeremy Fitzhardinge
2009-09-25 22:56 ` Brian Gerst
2009-09-25 23:22 ` Jeremy Fitzhardinge
2009-09-25 23:54 ` Brian Gerst
2009-09-26 0:22 ` Jeremy Fitzhardinge
2009-10-13 10:30 ` Ingo Molnar [this message]
2009-10-13 16:24 ` H. Peter Anvin
2009-10-13 16:53 ` Jeremy Fitzhardinge
2009-10-13 17:13 ` H. Peter Anvin
2009-10-13 17:55 ` H. Peter Anvin
2009-10-13 21:27 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013103044.GA3915@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox