From: Ingo Molnar <mingo@elte.hu>
To: Vincent Legoll <vincent.legoll@gmail.com>
Cc: Linux Kernel ML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>,
paulus@samba.org, a.p.zijlstra@chello.nl
Subject: Re: [PATCH] [PERF] do not manually count string lengths
Date: Tue, 13 Oct 2009 14:27:20 +0200 [thread overview]
Message-ID: <20091013122720.GA5561@elte.hu> (raw)
In-Reply-To: <4727185d0910130451h3a5adcebtc0c06f48b6c9ab99@mail.gmail.com>
* Vincent Legoll <vincent.legoll@gmail.com> wrote:
> On Tue, Oct 13, 2009 at 12:01 PM, Ingo Molnar <mingo@elte.hu> wrote:
> > We should add 'F:' file patterns to that entry i guess ...
> >
> > Something like:
> >
> > F: kernel/perf_event.c
> > F: include/linux/perf_event.h
> > F: arch/*/*/kernel/perf_event.c
> > F: arch/*/include/asm/perf_event.h
> > F: tools/perf/
> >
> > Would do the trick. Mind sending a patch for that too?
>
> Yep, I'll do, but a quick find in the tree may reveal other
> suspects that could be in the same league:
>
> $ find . -name .git -prune -false -o -name drivers -prune \
> -false -o -name '*perf*' | grep -v perfmon | grep -v gperf
>
> arch/*/kernel/perf_event.c
>
> arch/frv/lib/perf_event.c
> arch/x86/kernel/cpu/perf_event.c
>
> or maybe not:
>
> arch/powerpc/kernel/perf_callchain.c
> arch/parisc/kernel/perf_asm.S
> arch/parisc/kernel/perf_images.h
> arch/parisc/kernel/perf.c
> arch/parisc/include/asm/perf.h
>
> Was your list really comprehensive ?
ah, yes - perf_callchain.c too indeed. The pattern does not have to be
100% full coverage.
Ingo
next prev parent reply other threads:[~2009-10-13 12:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 8:18 [PATCH] [PERF] do not manually count string lengths Vincent Legoll
2009-10-13 10:01 ` Ingo Molnar
2009-10-13 11:51 ` Vincent Legoll
2009-10-13 12:27 ` Ingo Molnar [this message]
2009-10-13 12:48 ` Vincent Legoll
2009-10-13 12:58 ` Pekka Enberg
2009-10-13 13:34 ` [tip:perf/urgent] perf events: Update MAINTAINERS entry file patterns tip-bot for Vincent Legoll
2009-10-13 10:35 ` [tip:perf/core] perf tools: Do not manually count string lengths tip-bot for Vincent Legoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013122720.GA5561@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox