public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: scameron@beardog.cce.hp.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, mikem@beardog.cce.hp.com
Subject: Re: [PATCH] cciss: Add cciss_allow_hpsa module parameter.
Date: Tue, 13 Oct 2009 11:25:11 -0500	[thread overview]
Message-ID: <20091013162511.GZ23265@beardog.cce.hp.com> (raw)
In-Reply-To: <20091012150615.f9572d8a.akpm@linux-foundation.org>

On Mon, Oct 12, 2009 at 03:06:15PM -0700, Andrew Morton wrote:
> On Mon, 12 Oct 2009 10:36:25 -0500
> "Stephen M. Cameron" <scameron@beardog.cce.hp.com> wrote:
> 
> > Add cciss_allow_hpsa module parameter.  This parameter causes
> > the cciss driver to ignore any Smart Array devices known to be
> > supported by the hpsa driver.
> 
> An alternative approach would be to ensure that hpsa is loaded first. 
> Then when cciss tries to control a device it will fail to acquire that
> devices's PCI regions and will bale out in an orderly manner.
> 
> I don't know how we can reliably arrange for hpsa to execute first, but
> I'm sure someone does ;)
> 
> Unless CONFIG_CCISS=y, CONFIG_HPSA=m.  Then we're screwed.

My thinking was that with the module parameter, the default behavior
of cciss would be (almost*) unchanged, which would mean that people putting a
new kernel on an existing system would not get surprised when say,
 /dev/cciss/c0d0, likely their boot device, suddenly showed up as
/dev/sda instead, and their system wouldn't boot, their (old) Array
Configuration Utility didn't know what to make of hpsa, etc.

If somebody wants to switch to hpsa then they can via the module parameter,
but I think it's not a good idea to force them to switch at this time with no
real notice other than sudden failure to boot due to broken grub entries, 
fstab entries, etc.

(*the change in the default behavior would be that cciss would no longer load
on controllers which it doesn't explicitly know about.)

-- steve


  reply	other threads:[~2009-10-13 16:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 15:36 [PATCH] cciss: Add cciss_allow_hpsa module parameter Stephen M. Cameron
2009-10-12 22:06 ` Andrew Morton
2009-10-13 16:25   ` scameron [this message]
2009-10-13  7:17 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091013162511.GZ23265@beardog.cce.hp.com \
    --to=scameron@beardog.cce.hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikem@beardog.cce.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox