From: Andrew Morton <akpm@linux-foundation.org>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ixj: Fix test in ixj_selfprobe()
Date: Tue, 13 Oct 2009 16:54:03 -0700 [thread overview]
Message-ID: <20091013165403.7e553eb7.akpm@linux-foundation.org> (raw)
In-Reply-To: <4ACB6684.5010108@gmail.com>
On Tue, 06 Oct 2009 17:47:16 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:
> Not makes it a bool before the comparison.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Was below intended?
>
> diff --git a/drivers/telephony/ixj.c b/drivers/telephony/ixj.c
> index 40de151..da3c9a0 100644
> --- a/drivers/telephony/ixj.c
> +++ b/drivers/telephony/ixj.c
> @@ -6831,7 +6831,7 @@ static int ixj_selfprobe(IXJ *j)
> } else {
> switch (j->cardtype) {
> case QTI_PHONEJACK:
> - if (!j->dsp.low != 0x20) {
> + if (j->dsp.low != 0x20) {
> j->dsp.high = 0x80;
> j->dsp.low = 0x20;
> ixj_WriteDSPCommand(0x3800, j);
gee, I can't tell. Presumably it'd be safer to just delete the test -
it's a no-op at present and that code is well-tested, lol.
prev parent reply other threads:[~2009-10-13 23:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 15:47 [PATCH] ixj: Fix test in ixj_selfprobe() Roel Kluin
2009-10-13 23:54 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013165403.7e553eb7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).