From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: x86@kernel.org, yinghai@kernel.org, macro@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 3/3] x86,apic: limit apic dumping, introduce show_lapic setup option
Date: Wed, 14 Oct 2009 09:12:17 +0200 [thread overview]
Message-ID: <20091014071217.GL784@elte.hu> (raw)
In-Reply-To: <20091013201022.926793122@openvz.org>
* Cyrill Gorcunov <gorcunov@openvz.org> wrote:
> In case if a system has a large number of cpus printing apics
> contents may consume a long time period.
>
> We limit such an output by 1 apic by default. But to have an
> ability to see all apics or some part of them we introduce
> "show_lapic" setup option which allow us to limit/unlimit
> the number of APICs being dumped.
>
> Example: apic=debug show_lapic=5, or apic=debug show_lapic=all
>
> Also move apic_verbosity checking upper that way so helper routines
> do not need to inspect it at all.
>
> Suggested-by: Yinghai Lu <yinghai@kernel.org>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> ---
> arch/x86/kernel/apic/io_apic.c | 47 +++++++++++++++++++++++++++--------------
> 1 file changed, 32 insertions(+), 15 deletions(-)
> +__setup("show_lapic=", setup_show_lapic);
Note: new __setup() functions need an entry in
Documentation/kernel-parameters.txt as well.
Ingo
next prev parent reply other threads:[~2009-10-14 7:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 20:07 [patch 0/3] x86 apic series Cyrill Gorcunov
2009-10-13 20:07 ` [patch 1/3] x86,apic: introduce NOOP apic driver Cyrill Gorcunov
2009-10-14 8:17 ` [tip:x86/apic] x86, apic: Introduce the " tip-bot for Cyrill Gorcunov
2009-10-13 20:07 ` [patch 2/3] x86,apic -- use apic noop driver Cyrill Gorcunov
2009-10-14 8:17 ` [tip:x86/apic] x86, apic: Use " tip-bot for Cyrill Gorcunov
2009-10-13 20:07 ` [patch 3/3] x86,apic: limit apic dumping, introduce show_lapic setup option Cyrill Gorcunov
2009-10-14 7:12 ` Ingo Molnar [this message]
2009-10-14 7:51 ` Cyrill Gorcunov
2009-10-14 15:09 ` Cyrill Gorcunov
2009-10-14 15:40 ` [tip:x86/apic] x86, apic: Explain show_lapic= in kernel parameters list tip-bot for Cyrill Gorcunov
2009-10-14 17:56 ` [patch 3/3] x86,apic: limit apic dumping, introduce show_lapic setup option Ingo Molnar
2009-10-14 18:00 ` Cyrill Gorcunov
2009-10-14 18:20 ` Cyrill Gorcunov
2009-10-14 20:29 ` Cyrill Gorcunov
2009-10-15 14:27 ` Cyrill Gorcunov
2009-10-14 8:17 ` [tip:x86/apic] x86, apic: Limit apic dumping, introduce new show_lapic= " tip-bot for Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091014071217.GL784@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox