[PATCH] pata_sc1200: Fix crash on boot

[PATCH] pata_sc1200: Fix crash on boot

[Alan Cox]

The SC1200 needs a NULL terminator or it may cause a crash on boot.

Bug #14227

Also correct a bogus comment as the driver had serializing added so can run
dual port.

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 drivers/ata/pata_sc1200.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)


diff --git a/drivers/ata/pata_sc1200.c b/drivers/ata/pata_sc1200.c
index f49814d..3bbed83 100644
--- a/drivers/ata/pata_sc1200.c
+++ b/drivers/ata/pata_sc1200.c
@@ -235,8 +235,7 @@ static int sc1200_init_one(struct pci_dev *dev, const struct pci_device_id *id)
 		.udma_mask = ATA_UDMA2,
 		.port_ops = &sc1200_port_ops
 	};
-	/* Can't enable port 2 yet, see top comments */
-	const struct ata_port_info *ppi[] = { &info, };
+	const struct ata_port_info *ppi[] = { &info, NULL };
 
 	return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL);
 }

Re: [PATCH] pata_sc1200: Fix crash on boot

[Andrew Morton]

On Tue, 06 Oct 2009 16:07:51 +0100 Alan Cox <alan@linux.intel.com> wrote:

> The SC1200 needs a NULL terminator or it may cause a crash on boot.
> 
> Bug #14227
> 
> Also correct a bogus comment as the driver had serializing added so can run
> dual port.
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> 
>  drivers/ata/pata_sc1200.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/ata/pata_sc1200.c b/drivers/ata/pata_sc1200.c
> index f49814d..3bbed83 100644
> --- a/drivers/ata/pata_sc1200.c
> +++ b/drivers/ata/pata_sc1200.c
> @@ -235,8 +235,7 @@ static int sc1200_init_one(struct pci_dev *dev, const struct pci_device_id *id)
>  		.udma_mask = ATA_UDMA2,
>  		.port_ops = &sc1200_port_ops
>  	};
> -	/* Can't enable port 2 yet, see top comments */
> -	const struct ata_port_info *ppi[] = { &info, };
> +	const struct ata_port_info *ppi[] = { &info, NULL };
>  
>  	return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL);
>  }

This patch applies to 2.6.31 and 2.6.30 (at least).  How far back
should it be ported?

There was no Cc:stable in the changelog.

There was no Cc:stable in the mail headers.  Nor cc:linux-ide.

Adding a Reported-by: is nice.

Please use the form

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14227

when mentioning bugzilla reports within changelogs.  To provide a nice
greppable pattern for those people who might close off old reports for us.

Re: [PATCH] pata_sc1200: Fix crash on boot

[Alexandros C. Couloumbis]

On Tue, 13 Oct 2009 18:56:37 -0700, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Tue, 06 Oct 2009 16:07:51 +0100 Alan Cox <alan@linux.intel.com>
wrote:
> 
>> The SC1200 needs a NULL terminator or it may cause a crash on boot.
>> 
>> Bug #14227
>> 
>> Also correct a bogus comment as the driver had serializing added so can
>> run
>> dual port.
>> 
>> Signed-off-by: Alan Cox <alan@linux.intel.com>
>> ---
>> 
>>  drivers/ata/pata_sc1200.c |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>> 
>> 
>> diff --git a/drivers/ata/pata_sc1200.c b/drivers/ata/pata_sc1200.c
>> index f49814d..3bbed83 100644
>> --- a/drivers/ata/pata_sc1200.c
>> +++ b/drivers/ata/pata_sc1200.c
>> @@ -235,8 +235,7 @@ static int sc1200_init_one(struct pci_dev *dev,
>> const struct pci_device_id *id)
>>  		.udma_mask = ATA_UDMA2,
>>  		.port_ops = &sc1200_port_ops
>>  	};
>> -	/* Can't enable port 2 yet, see top comments */
>> -	const struct ata_port_info *ppi[] = { &info, };
>> +	const struct ata_port_info *ppi[] = { &info, NULL };
>>  
>>  	return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL);
>>  }
> 
> This patch applies to 2.6.31 and 2.6.30 (at least).  How far back
> should it be ported?
> 
> There was no Cc:stable in the changelog.
> 
> There was no Cc:stable in the mail headers.  Nor cc:linux-ide.
> 
> Adding a Reported-by: is nice.
> 
> Please use the form
> 
> Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14227
> 
> when mentioning bugzilla reports within changelogs.  To provide a nice
> greppable pattern for those people who might close off old reports for
us.

According to the git-tree this feature was introduced on linux kernel
2.6.30:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.30.y.git;a=commitdiff;h=c0f2ee34a5a0b79fd98d965ad8ae765d4639bfa5

2.6.29 and older kernels do not have this change/feature

Re: [PATCH] pata_sc1200: Fix crash on boot

[Alan Cox]

> This patch applies to 2.6.31 and 2.6.30 (at least).  How far back
> should it be ported?

No idea. I was just getting it fixed for the maintainer while waiting for
something else to build.

Re: [PATCH] pata_sc1200: Fix crash on boot

[Bartlomiej Zolnierkiewicz]

On Wednesday 14 October 2009 14:00:46 Alan Cox wrote:
> > This patch applies to 2.6.31 and 2.6.30 (at least).  How far back
> > should it be ported?
> 
> No idea. I was just getting it fixed for the maintainer while waiting for
> something else to build.

BTW do you happen to know who is the current maintainer of this driver
(ditto for other PATA drivers)?

MAINTAINERS lists only:

	SERIAL ATA (SATA) SUBSYSTEM
	P:      Jeff Garzik
	M:      jgarzik@pobox.com
	L:      linux-ide@vger.kernel.org
	T:      git git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
	S:      Supported
	F:      drivers/ata/
	F:      include/linux/ata.h
	F:      include/linux/libata.h

but this driver surely ain't SATA.

Re: [PATCH] pata_sc1200: Fix crash on boot

[Alan Cox]

> BTW do you happen to know who is the current maintainer of this driver
> (ditto for other PATA drivers)?
> 
> MAINTAINERS lists only:
> 
> 	SERIAL ATA (SATA) SUBSYSTEM
> 	P:      Jeff Garzik
> 	M:      jgarzik@pobox.com
> 	L:      linux-ide@vger.kernel.org
> 	T:      git git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
> 	S:      Supported
> 	F:      drivers/ata/
> 	F:      include/linux/ata.h
> 	F:      include/linux/libata.h
> 
> but this driver surely ain't SATA.

The subsystem wants renaming. Patches go to Jeff who though he rarely
appears on listy and stuff keeps the tree and is doing all the submission
stuff.

Alan

Re: [PATCH] pata_sc1200: Fix crash on boot

[Jeff Garzik]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

On 10/14/2009 08:12 AM, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday 14 October 2009 14:00:46 Alan Cox wrote:
>>> This patch applies to 2.6.31 and 2.6.30 (at least).  How far back
>>> should it be ported?
>>
>> No idea. I was just getting it fixed for the maintainer while waiting for
>> something else to build.
>
> BTW do you happen to know who is the current maintainer of this driver
> (ditto for other PATA drivers)?
>
> MAINTAINERS lists only:
>
> 	SERIAL ATA (SATA) SUBSYSTEM
> 	P:      Jeff Garzik
> 	M:      jgarzik@pobox.com
> 	L:      linux-ide@vger.kernel.org
> 	T:      git git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
> 	S:      Supported
> 	F:      drivers/ata/
> 	F:      include/linux/ata.h
> 	F:      include/linux/libata.h
>
> but this driver surely ain't SATA.

FWIW, I've been treating Alan as "PATA sub-maintainer", and tend to wait 
for an Alan review of a PATA driver patch before applying it [unless 
it's blindingly obvious or Bart chimes etc.].

But yes, overall, libata is certainly not SATA-only anymore, and 
MAINTAINERS should reflect that.

Maybe a patch like the attached?  (DaveM CC'd, since I modified the 
old-IDE entry as well)

	Jeff



[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 691 bytes --]

diff --git a/MAINTAINERS b/MAINTAINERS
index 69e31aa..1a756bd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2581,7 +2581,7 @@ W:	http://www.developer.ibm.com/welcome/netfinity/serveraid.html
 S:	Supported
 F:	drivers/scsi/ips.*
 
-IDE SUBSYSTEM
+Old IDE SUBSYSTEM
 M:	"David S. Miller" <davem@davemloft.net>
 L:	linux-ide@vger.kernel.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide-2.6.git
@@ -4644,7 +4644,7 @@ S:	Maintained
 F:	drivers/misc/phantom.c
 F:	include/linux/phantom.h
 
-SERIAL ATA (SATA) SUBSYSTEM
+ATA SUBSYSTEM
 M:	Jeff Garzik <jgarzik@pobox.com>
 L:	linux-ide@vger.kernel.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git

Re: [PATCH] pata_sc1200: Fix crash on boot

[Alan Cox]

> This patch applies to 2.6.31 and 2.6.30 (at least).  How far back
> should it be ported?

Having had a dig the bug was introduced in
c0f2ee34a5a0b79fd98d965ad8ae765d4639bfa5

I've not however tested the patch with any older releases.

Alan

Re: [PATCH] pata_sc1200: Fix crash on boot

[Jeff Garzik]

On 10/06/2009 11:07 AM, Alan Cox wrote:
> The SC1200 needs a NULL terminator or it may cause a crash on boot.
>
> Bug #14227
>
> Also correct a bogus comment as the driver had serializing added so can run
> dual port.
>
> Signed-off-by: Alan Cox<alan@linux.intel.com>
> ---
>
>   drivers/ata/pata_sc1200.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)

applied