Re: [PATCH tip/core/rcu 5/6] rcu: add rnp->blocked_tasks to tracing

Paul E. McKenney
2009-10-14T23:37:19Z

On Wed, Oct 14, 2009 at 01:26:50PM -0700, Josh Triplett wrote:
> On Wed, Oct 14, 2009 at 10:15:58AM -0700, Paul E. McKenney wrote:
> > From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > ---
> > kernel/rcutree_trace.c | 7 +++++--
> > 1 files changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c
> > index 4b31c77..f9d01a3 100644
> > --- a/kernel/rcutree_trace.c
> > +++ b/kernel/rcutree_trace.c
> > @@ -155,12 +155,13 @@ static const struct file_operations rcudata_csv_fops = {
> >
> > static void print_one_rcu_state(struct seq_file *m, struct rcu_state *rsp)
> > {
> > + long gpnum;
> > int level = 0;
> > struct rcu_node *rnp;
> >
> > seq_printf(m, "c=%ld g=%ld s=%d jfq=%ld j=%x "
> > "nfqs=%lu/nfqsng=%lu(%lu) fqlh=%lu oqlen=%ld\n",
> > - rsp->completed, rsp->gpnum, rsp->signaled,
> > + rsp->completed, gpnum = rsp->gpnum, rsp->signaled,
>
> Please don't hide this or any other assignment in the middle of a print
> statement. Just put it immediately preceeding the statement.

Good point, here is the updated patch.

Thanx, Paul

rcu: add rnp->blocked_tasks to tracing

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

rcutree_trace.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/kernel/rcutree_trace.c b/kernel/rcutree_trace.c
index 4b31c77..1984cdc 100644
--- a/kernel/rcutree_trace.c
+++ b/kernel/rcutree_trace.c
@@ -155,12 +155,14 @@ static const struct file_operations rcudata_csv_fops = {

static void print_one_rcu_state(struct seq_file *m, struct rcu_state *rsp)
{
+ long gpnum;
int level = 0;
struct rcu_node *rnp;

+ gpnum = rsp->gpnum;
seq_printf(m, "c=%ld g=%ld s=%d jfq=%ld j=%x "
"nfqs=%lu/nfqsng=%lu(%lu) fqlh=%lu oqlen=%ld\n",
- rsp->completed, rsp->gpnum, rsp->signaled,
+ rsp->completed, gpnum, rsp->signaled,
(long)(rsp->jiffies_force_qs - jiffies),
(int)(jiffies & 0xffff),
rsp->n_force_qs, rsp->n_force_qs_ngp,
@@ -171,8 +173,10 @@ static void print_one_rcu_state(struct seq_file *m, struct rcu_state *rsp)
seq_puts(m, "\n");
level = rnp->level;
}
- seq_printf(m, "%lx/%lx %d:%d ^%d ",
+ seq_printf(m, "%lx/%lx %c>%c %d:%d ^%d ",
rnp->qsmask, rnp->qsmaskinit,
+ "T."[list_empty(&rnp->blocked_tasks[gpnum & 1])],
+ "T."[list_empty(&rnp->blocked_tasks[!(gpnum & 1)])],
rnp->grplo, rnp->grphi, rnp->grpnum);
}
seq_puts(m, "\n");