From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758524AbZJOSlX (ORCPT ); Thu, 15 Oct 2009 14:41:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757273AbZJOSlW (ORCPT ); Thu, 15 Oct 2009 14:41:22 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:43999 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756389AbZJOSlV (ORCPT ); Thu, 15 Oct 2009 14:41:21 -0400 Date: Thu, 15 Oct 2009 09:14:19 -0700 From: "Paul E. McKenney" To: Ingo Molnar Cc: Josh Triplett , linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, npiggin@suse.de, jens.axboe@oracle.com Subject: Re: [PATCH tip/core/rcu 0/6] rcu: fix synchronize_rcu_expedited(), update docs, improve perf Message-ID: <20091015161419.GC6706@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20091014171517.GA13635@linux.vnet.ibm.com> <20091015092155.GD10546@elte.hu> <20091015093541.GA8057@feather> <20091015111944.GA29080@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091015111944.GA29080@elte.hu> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 15, 2009 at 01:19:44PM +0200, Ingo Molnar wrote: > > * Josh Triplett wrote: > > > On Thu, Oct 15, 2009 at 11:21:55AM +0200, Ingo Molnar wrote: > > > * Paul E. McKenney wrote: > > > > > > > This patchset contains a bug fix, a performance improvement, and > > > > documentation updates: > > > > > > > > o Update Documentation/RCU/trace.txt to reflect recent changes > > > > (including the removal of rcupreempt.c). > > > > > > i've applied this to the .33 queue. > > > > I realize this only represents a documentation change, but it updates > > the documentation to match the code in 2.6.32, which seems worth > > doing. > > > > > > o Add the new rnp->blocked_tasks field to the rcuhier trace file > > > > in debugfs. > > > > > > > > o Update the Documentation/RCU/trace.txt documentation to include > > > > the rnp->blocked_tasks tracing. > > > > > > i've applied these to the .33 queue as well. (both tracing and > > > documentation is not urgent material.) I also did minor edits to the > > > changelogs. > > > > Those who debug RCU-related issues would disagree that having adequate > > tracing information proves non-urgent. :) The tracing information this > > adds proves essential for debugging issues with the new hierarchical > > RCU. (And the documentation patch just documents the added tracing > > information, so both should go together as a unit; actually, perhaps > > they should get merged.) > > No, we generally dont do such changes so late in -rc's (these would hit > upstream in -rc6 - which is too late). > > People doing development will use the latest RCU tree so the practical > impact is small. Furthermore, we had a higher than usual rate of > post-rc1 RCU changes in this cycle already, it needs to cool down a bit. Works for me! I can supply appropriate diffs off of one of the -rc releases if people need this in order to experiment with recent RCU patches. (But I get to choose the -rc!) Thanx, Paul