From: Alexey Dobriyan <adobriyan@gmail.com>
To: akpm@linux-foundation.org
Cc: rjw@sisk.pl, htmldeveloper@gmail.com, ebiederm@xmission.com,
linux-kernel@vger.kernel.org
Subject: [PATCH] sysctl: fix false positives when PROC_SYSCTL=n
Date: Fri, 16 Oct 2009 04:28:37 +0400 [thread overview]
Message-ID: <20091016002837.GA4185@x200> (raw)
In-Reply-To: <m1tyy0i7tm.fsf@fess.ebiederm.org>
Having ->procname but not ->proc_handler is valid when PROC_SYSCTL=n,
people use such combination to reduce ifdefs with non-standard handlers.
http://bugzilla.kernel.org/show_bug.cgi?id=14408
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
kernel/sysctl_check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/sysctl_check.c
+++ b/kernel/sysctl_check.c
@@ -1521,7 +1521,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
if (!table->ctl_name && table->strategy)
set_fail(&fail, table, "Strategy without ctl_name");
#endif
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_PROC_SYSCTL
if (table->procname && !table->proc_handler)
set_fail(&fail, table, "No proc_handler");
#endif
next parent reply other threads:[~2009-10-16 0:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-14408-10286@http.bugzilla.kernel.org/>
[not found] ` <20091015132323.bea94a13.akpm@linux-foundation.org>
[not found] ` <m1tyy0i7tm.fsf@fess.ebiederm.org>
2009-10-16 0:28 ` Alexey Dobriyan [this message]
2009-10-16 9:42 ` [PATCH] sysctl: fix false positives when PROC_SYSCTL=n Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091016002837.GA4185@x200 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=htmldeveloper@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox