* [PATCH] sysctl: fix false positives when PROC_SYSCTL=n
[not found] ` <m1tyy0i7tm.fsf@fess.ebiederm.org>
@ 2009-10-16 0:28 ` Alexey Dobriyan
2009-10-16 9:42 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2009-10-16 0:28 UTC (permalink / raw)
To: akpm; +Cc: rjw, htmldeveloper, ebiederm, linux-kernel
Having ->procname but not ->proc_handler is valid when PROC_SYSCTL=n,
people use such combination to reduce ifdefs with non-standard handlers.
http://bugzilla.kernel.org/show_bug.cgi?id=14408
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
kernel/sysctl_check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/sysctl_check.c
+++ b/kernel/sysctl_check.c
@@ -1521,7 +1521,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
if (!table->ctl_name && table->strategy)
set_fail(&fail, table, "Strategy without ctl_name");
#endif
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_PROC_SYSCTL
if (table->procname && !table->proc_handler)
set_fail(&fail, table, "No proc_handler");
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sysctl: fix false positives when PROC_SYSCTL=n
2009-10-16 0:28 ` [PATCH] sysctl: fix false positives when PROC_SYSCTL=n Alexey Dobriyan
@ 2009-10-16 9:42 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2009-10-16 9:42 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: akpm, rjw, htmldeveloper, linux-kernel
Alexey Dobriyan <adobriyan@gmail.com> writes:
> Having ->procname but not ->proc_handler is valid when PROC_SYSCTL=n,
> people use such combination to reduce ifdefs with non-standard handlers.
>
> http://bugzilla.kernel.org/show_bug.cgi?id=14408
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
It looks like I messed up when I wrote sysctl_check.c and used the
wrong ifdef. Silly me. Especially since I had added PROC_SYSCTL
earlier.
Eric
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> kernel/sysctl_check.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/kernel/sysctl_check.c
> +++ b/kernel/sysctl_check.c
> @@ -1521,7 +1521,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
> if (!table->ctl_name && table->strategy)
> set_fail(&fail, table, "Strategy without ctl_name");
> #endif
> -#ifdef CONFIG_PROC_FS
> +#ifdef CONFIG_PROC_SYSCTL
> if (table->procname && !table->proc_handler)
> set_fail(&fail, table, "No proc_handler");
> #endif
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-16 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <bug-14408-10286@http.bugzilla.kernel.org/>
[not found] ` <20091015132323.bea94a13.akpm@linux-foundation.org>
[not found] ` <m1tyy0i7tm.fsf@fess.ebiederm.org>
2009-10-16 0:28 ` [PATCH] sysctl: fix false positives when PROC_SYSCTL=n Alexey Dobriyan
2009-10-16 9:42 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox