public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@lst.de>
Cc: fweisbec@gmail.com, linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: perf trace errors
Date: Fri, 16 Oct 2009 10:32:42 +0200	[thread overview]
Message-ID: <20091016083242.GA11174@elte.hu> (raw)
In-Reply-To: <20091011025441.GA18152@lst.de>


* Christoph Hellwig <hch@lst.de> wrote:

> I get some rather interesting errors using perf trace with the block
> tracepoints on current mainline, e.g.:
> 
> perf record -f -e 'block:block_bio_queue:record' -R -F 1 -a -s
> <do some disk I/O end then ctrl+c>
> ^C[ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.237 MB perf.data (~10362 samples) ]
> 
> brick:/home/hch# perf trace
>   Fatal: unknown op '-'
>           xfssyncd-4232  [000]    87.798249255: block_bio_queue: 253,
> 
> There are lots of occurances of that exactly same warning in 
> builtin-trace.c, and the code sourrouning them is sufficiently enough 
> convoluted that I'm not able to track it down.

FYI, these bugs are fixed in latest -tip, your testcase works for me:

aldebaran:~/linux/linux/tools/perf> perf record -f -e 'block:block_bio_queue:record' -R -F 1 -a -s
^C[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.027 MB perf.data (~1168 samples) ]

aldebaran:~/linux/linux/tools/perf> perf trace
       kjournald-1406  [000] 10900.853086: block_bio_queue: 8,0 W 68735 + 8 [kjournald]
       kjournald-1406  [000] 10900.853097: block_bio_queue: 8,0 W 68743 + 8 [kjournald]
       kjournald-1406  [000] 10900.853100: block_bio_queue: 8,0 W 68751 + 8 [kjournald]
       kjournald-1406  [000] 10900.853103: block_bio_queue: 8,0 W 68759 + 8 [kjournald]
       flush-8:0-20110 [007] 10900.853117: block_bio_queue: 8,0 W 64487535 + 8 [flush-8:0]
       flush-8:0-20110 [007] 10900.853129: block_bio_queue: 8,0 W 64487551 + 8 [flush-8:0]
       flush-8:0-20110 [007] 10900.853138: block_bio_queue: 8,0 W 64487559 + 8 [flush-8:0]
       flush-8:0-20110 [007] 10900.853149: block_bio_queue: 8,0 W 64700511 + 8 [flush-8:0]
            sync-16876 [008] 10900.851948: block_bio_queue: 8,0 R 3218919 + 40 [sync]
            sync-16876 [008] 10900.853062: block_bio_queue: 8,0 W 63 + 8 [sync]
            sync-16876 [008] 10900.853067: block_bio_queue: 8,0 W 71 + 8 [sync]
            sync-16876 [008] 10900.853071: block_bio_queue: 8,0 W 79 + 8 [sync]
            sync-16876 [008] 10900.853077: block_bio_queue: 8,0 W 15466559 + 8 [sync]
            sync-16876 [011] 10900.840473: block_bio_queue: 8,0 R 3218887 + 32 [bash]

Mind checking whether it works for you?

Thanks,

	Ingo

  parent reply	other threads:[~2009-10-16  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-11  2:54 perf trace errors Christoph Hellwig
2009-10-11 12:19 ` Frederic Weisbecker
2009-10-11 12:40   ` Christoph Hellwig
2009-10-11 20:23     ` Frederic Weisbecker
2009-10-16  8:32 ` Ingo Molnar [this message]
2009-10-25  7:17   ` Christoph Hellwig
2009-10-25 23:43     ` Frederic Weisbecker
2009-10-29 21:24       ` Steven Rostedt
2009-11-02  1:24         ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091016083242.GA11174@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox