From: Greg KH <greg@kroah.com>
To: Alan Jenkins <sourcejedi.lkml@googlemail.com>
Cc: carmelo73@gmail.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: Fast LKM symbol resolution with SysV ELH hash table
Date: Sun, 18 Oct 2009 14:47:04 -0700 [thread overview]
Message-ID: <20091018214704.GA26592@kroah.com> (raw)
In-Reply-To: <9b2b86520910180544g94ecc8fuf0d7849e18cd8937@mail.gmail.com>
On Sun, Oct 18, 2009 at 01:44:04PM +0100, Alan Jenkins wrote:
> Hypothetically: imagine we both finish our work and testing on the
> same machine shows hash tables saving 100% and bsearch saving 90%. In
> absolute terms, hash tables might have an advantage of 0.03s on my
> system (where bsearch saved 0.3s), and a total advantage of 0.015s for
> the modules you tested (where hash tables saved ~0.15s).
>
> Would you accept bsearch in this case? Or would you feel that the
> performance of hash tables outweighed the extra memory requirements?
The performance difference in "raw" time speed might be much different
on embedded platforms with slower processors, so it might be worth the
tiny complexity to get that much noticed speed.
> (This leaves the question of why you need to load 0.015s worth of
> always-needed in-tree kernel code as modules. For those who haven't
> read the slides, the reasoning is that built-in code would take
> _longer_ to load. The boot-loader is often slower at IO, and it
> doesn't allow other initialization to occur in parallel).
Distros are forced to build almost everything as modules. I've played
with building some modules into the kernel directly (see the openSUSE
moblin kernels for examples of that), but when you have to suport a much
larger range of hardware types and features that some users use and
others don't, and the ability to override specific drivers by others due
to manufacturer requests for specific updates, the need to keep things
as modules is the only way to solve the problem.
So I'm glad to see this speedup happen, very nice work everyone.
thanks,
greg k-h
next prev parent reply other threads:[~2009-10-18 21:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 8:09 Fast LKM symbol resolution with SysV ELH hash table Carmelo Amoroso
2009-10-18 12:44 ` Alan Jenkins
2009-10-18 16:43 ` Alan Jenkins
2009-10-18 21:47 ` Greg KH [this message]
2009-10-19 0:01 ` Alan Jenkins
2009-10-19 11:45 ` Carmelo Amoroso
2009-10-19 13:22 ` Greg KH
2009-10-19 15:02 ` Carmelo Amoroso
2009-10-19 19:10 ` Greg KH
2009-10-19 20:46 ` Alan Jenkins
2009-10-20 0:56 ` Rusty Russell
2009-10-21 5:43 ` Robert Hancock
2009-10-21 13:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091018214704.GA26592@kroah.com \
--to=greg@kroah.com \
--cc=carmelo73@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox