From: Li Hong <lihong.hi@gmail.com>
To: Borislav Petkov <borislav.petkov@amd.com>,
Doug Thompson <dougthompson@xmission.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] amd64_edac: fix a wrong goto clause in amd64_edac.c
Date: Mon, 19 Oct 2009 16:33:29 +0800 [thread overview]
Message-ID: <20091019083329.GA7340@uhli> (raw)
In amd64_edac_init(void) in amd64_edac.c, cache_k8_northbridges() is called
before pci_register_driver. If it fails, should exit with err directly.
Signed-off-by: Li Hong <lihong.hi@gmail.com>
---
drivers/edac/amd64_edac.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index d4560d9..3ee539a 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -3163,7 +3163,7 @@ static int __init amd64_edac_init(void)
opstate_init();
if (cache_k8_northbridges() < 0)
- goto err_exit;
+ return err;
err = pci_register_driver(&amd64_pci_driver);
if (err)
@@ -3189,8 +3189,6 @@ static int __init amd64_edac_init(void)
err_2nd_stage:
debugf0("2nd stage failed\n");
-
-err_exit:
pci_unregister_driver(&amd64_pci_driver);
return err;
--
1.6.0.4
next reply other threads:[~2009-10-19 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 8:33 Li Hong [this message]
2009-10-19 12:52 ` [PATCH] amd64_edac: fix a wrong goto clause in amd64_edac.c Borislav Petkov
2009-10-20 1:39 ` Li Hong
2009-10-19 14:58 ` Doug Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019083329.GA7340@uhli \
--to=lihong.hi@gmail.com \
--cc=borislav.petkov@amd.com \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox