From: Ingo Molnar <mingo@elte.hu>
To: Robin Holt <holt@sgi.com>
Cc: tglx@linutronix.de, Jack Steiner <steiner@sgi.com>,
linux-kernel@vger.kernel.org, stable@kernel.org,
Martin Hicks <mort@sgi.com>
Subject: Re: [patch 1/1] x86, UV: uv_hub_send_ipi Needs to set DELIVERY_MODE=4 for vector=NMI_VECTOR.
Date: Mon, 19 Oct 2009 15:08:21 +0200 [thread overview]
Message-ID: <20091019130821.GC9030@elte.hu> (raw)
In-Reply-To: <20091019091919.050247000@alcatraz.americas.sgi.com>
* Robin Holt <holt@sgi.com> wrote:
> When sending a NMI_VECTOR IPI using the UV_HUB_IPI_INT register,
> we need to ensure the delivery mode field of that register has NMI
> delivery selected.
>
> To: Ingo Molnar <mingo@elte.hu>
> To: tglx@linutronix.de
> Signed-off-by: Robin Holt <holt@sgi.com>
> Acked-by: Jack Steiner <steiner@sgi.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@kernel.org
> Cc: Martin Hicks <mort@sgi.com>
>
> ---
> arch/x86/include/asm/uv/uv_hub.h | 6 ++++++
> 1 file changed, 6 insertions(+)
> Index: linux-x86/arch/x86/include/asm/uv/uv_hub.h
> ===================================================================
> --- linux-x86.orig/arch/x86/include/asm/uv/uv_hub.h 2009-10-19 04:07:07.000000000 -0500
> +++ linux-x86/arch/x86/include/asm/uv/uv_hub.h 2009-10-19 04:07:09.000000000 -0500
> @@ -19,6 +19,7 @@
> #include <asm/types.h>
> #include <asm/percpu.h>
> #include <asm/uv/uv_mmrs.h>
> +#include <asm/irq_vectors.h>
>
>
> /*
> @@ -435,9 +436,14 @@ static inline void uv_set_cpu_scir_bits(
> static inline void uv_hub_send_ipi(int pnode, int apicid, int vector)
> {
> unsigned long val;
> + unsigned long dmode = 0; /* Directed Delivery */
> +
> + if (vector == NMI_VECTOR)
> + dmode = 4; /* NMI Delivery */
>
> val = (1UL << UVH_IPI_INT_SEND_SHFT) |
> ((apicid) << UVH_IPI_INT_APIC_ID_SHFT) |
> + (dmode << UVH_IPI_INT_DELIVERY_MODE_SHFT) |
> (vector << UVH_IPI_INT_VECTOR_SHFT);
> uv_write_global_mmr64(pnode, UVH_IPI_INT, val);
Hm, would be cleaner to create an enum for that '4' (and for 0) in
uv_mmrs.h and use it here. (We have similar constants for delivery modes
in io_apic.h, see dest_*.)
Ingo
next prev parent reply other threads:[~2009-10-19 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091019091854.696198000@alcatraz.americas.sgi.com>
2009-10-19 9:18 ` [patch 1/1] x86, UV: uv_hub_send_ipi Needs to set DELIVERY_MODE=4 for vector=NMI_VECTOR Robin Holt
2009-10-19 13:08 ` Ingo Molnar [this message]
2009-10-20 19:09 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019130821.GC9030@elte.hu \
--to=mingo@elte.hu \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mort@sgi.com \
--cc=stable@kernel.org \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox