From: Alex Chiang <achiang@hp.com>
To: =shaohua.li@intel.com, lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 3/6] ACPI: dock: remove global 'dock_device_name'
Date: Mon, 19 Oct 2009 15:14:35 -0600 [thread overview]
Message-ID: <20091019211434.5412.13924.stgit@bob.kio> (raw)
In-Reply-To: <20091019211132.5412.80438.stgit@bob.kio>
We only use it in one spot, so it probably gets optimized out, but there's
still no need to use a global variable for this.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
drivers/acpi/dock.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 347ea98..45bdff7 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -50,7 +50,6 @@ MODULE_PARM_DESC(immediate_undock, "1 (default) will cause the driver to "
" before undocking");
static struct atomic_notifier_head dock_notifier_list;
-static char dock_device_name[] = "dock";
static const struct acpi_device_id dock_device_ids[] = {
{"LNXDOCK", 0},
@@ -964,7 +963,7 @@ static int dock_add(acpi_handle handle)
/* initialize platform device stuff */
dock_station->dock_device =
- platform_device_register_simple(dock_device_name,
+ platform_device_register_simple("dock",
dock_station_count, NULL, 0);
dock_device = dock_station->dock_device;
if (IS_ERR(dock_device)) {
next prev parent reply other threads:[~2009-10-19 21:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 21:14 [PATCH v4 0/6] ACPI: dock: code hygiene Alex Chiang
2009-10-19 21:14 ` [PATCH v4 1/6] ACPI: dock: convert sysfs attributes to an attribute_group Alex Chiang
2009-10-20 1:38 ` Dmitry Torokhov
2009-10-20 2:57 ` Alex Chiang
2009-10-20 3:26 ` Dmitry Torokhov
2009-10-19 21:14 ` [PATCH v4 2/6] ACPI: dock: combine add|alloc_dock_dependent_device Alex Chiang
2009-10-19 21:14 ` Alex Chiang [this message]
2009-10-19 21:14 ` [PATCH v4 4/6] ACPI: dock: dock_add - hoist up platform_device_register_simple() Alex Chiang
2009-10-19 21:14 ` [PATCH v4 5/6] ACPI: dock: add struct dock_station * directly to platform device data Alex Chiang
2009-10-19 21:14 ` [PATCH v4 6/6] ACPI: dock: minor whitespace and style cleanups Alex Chiang
2009-10-29 0:07 ` [PATCH v4 0/6] ACPI: dock: code hygiene Alex Chiang
2009-10-29 1:00 ` Shaohua Li
2009-11-03 20:55 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019211434.5412.13924.stgit@bob.kio \
--to=achiang@hp.com \
--cc==shaohua.li@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox