Re: [PATCH v4 0/6] ACPI: dock: code hygiene

Shaohua Li
2009-10-29T01:00:33Z

On Thu, Oct 29, 2009 at 08:07:43AM +0800, Alex Chiang wrote:
> Hi Len, Shaohua,
>
> Any comments on this patch series?
>
> I did fat-finger Shaohua's email address when I sent out v4, but
> I thought I bounced all the mails to him privately, off-list.
I'm ok with the series.

Thanks,
Shaohua
> * Alex Chiang <achiang@hp.com>:
> > This is v4 of a modest attempt to clean up the dock driver.
> >
> > As before, compile tested only, since I don't have any machines
> > that provide _DCK.
> >
> > Thanks.
> > /ac
> >
> > v3 -> v4:
> > - defensively code in case sysfs_create_group() fails and
> > sysfs_remove_group() can't handle removing a non-existent group;
> > suggested by Dmitry Torokhov
> >
> > v2 -> v3:
> > - now using an attribute_group, as suggested by Dmitry Torokhov
> >
> > v1 -> v2:
> > - changed how we add platform device data, based on Shaohua Li's
> > review
> > ---
> >
> > Alex Chiang (6):
> > ACPI: dock: convert sysfs attributes to an attribute_group
> > ACPI: dock: combine add|alloc_dock_dependent_device
> > ACPI: dock: remove global 'dock_device_name'
> > ACPI: dock: dock_add - hoist up platform_device_register_simple()
> > ACPI: dock: add struct dock_station * directly to platform device data
> > ACPI: dock: minor whitespace and style cleanups
> >
> >
> > drivers/acpi/dock.c | 266 ++++++++++++++++++---------------------------------
> > 1 files changed, 93 insertions(+), 173 deletions(-)
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html