* [PATCH] mfd: Staticise __adp5520_ack_bits()
@ 2009-10-19 14:46 Mark Brown
2009-10-19 15:09 ` Hennerich, Michael
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2009-10-19 14:46 UTC (permalink / raw)
To: Samuel Ortiz, Mike Frysinger, Michael Hennerich, Bryan Wu
Cc: linux-kernel, Mark Brown
The function is not exported as the __ indicates. __
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/mfd/adp5520.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
index 401a9b6..b266447 100644
--- a/drivers/mfd/adp5520.c
+++ b/drivers/mfd/adp5520.c
@@ -66,7 +66,8 @@ static int __adp5520_write(struct i2c_client *client,
return 0;
}
-int __adp5520_ack_bits(struct i2c_client *client, int reg, uint8_t bit_mask)
+static int __adp5520_ack_bits(struct i2c_client *client, int reg,
+ uint8_t bit_mask)
{
struct adp5520_chip *chip = i2c_get_clientdata(client);
uint8_t reg_val;
--
1.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] mfd: Staticise __adp5520_ack_bits()
2009-10-19 14:46 [PATCH] mfd: Staticise __adp5520_ack_bits() Mark Brown
@ 2009-10-19 15:09 ` Hennerich, Michael
2009-10-19 22:26 ` Samuel Ortiz
0 siblings, 1 reply; 3+ messages in thread
From: Hennerich, Michael @ 2009-10-19 15:09 UTC (permalink / raw)
To: Mark Brown, Samuel Ortiz, Mike Frysinger, Bryan Wu; +Cc: linux-kernel
>From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
>The function is not exported as the __ indicates. __
>
>Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
>---
> drivers/mfd/adp5520.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
>index 401a9b6..b266447 100644
>--- a/drivers/mfd/adp5520.c
>+++ b/drivers/mfd/adp5520.c
>@@ -66,7 +66,8 @@ static int __adp5520_write(struct i2c_client *client,
> return 0;
> }
>
>-int __adp5520_ack_bits(struct i2c_client *client, int reg, uint8_t
bit_mask)
>+static int __adp5520_ack_bits(struct i2c_client *client, int reg,
>+ uint8_t bit_mask)
> {
> struct adp5520_chip *chip = i2c_get_clientdata(client);
> uint8_t reg_val;
>--
>1.6.5
-Michael
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: Staticise __adp5520_ack_bits()
2009-10-19 15:09 ` Hennerich, Michael
@ 2009-10-19 22:26 ` Samuel Ortiz
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2009-10-19 22:26 UTC (permalink / raw)
To: Hennerich, Michael; +Cc: Mark Brown, Mike Frysinger, Bryan Wu, linux-kernel
On Mon, Oct 19, 2009 at 04:09:07PM +0100, Hennerich, Michael wrote:
> >From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> >The function is not exported as the __ indicates. __
> >
> >Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
>
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Thanks guys, applied to my for-next branch.
Cheers,
Samuel.
>
> >---
> > drivers/mfd/adp5520.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
> >index 401a9b6..b266447 100644
> >--- a/drivers/mfd/adp5520.c
> >+++ b/drivers/mfd/adp5520.c
> >@@ -66,7 +66,8 @@ static int __adp5520_write(struct i2c_client *client,
> > return 0;
> > }
> >
> >-int __adp5520_ack_bits(struct i2c_client *client, int reg, uint8_t
> bit_mask)
> >+static int __adp5520_ack_bits(struct i2c_client *client, int reg,
> >+ uint8_t bit_mask)
> > {
> > struct adp5520_chip *chip = i2c_get_clientdata(client);
> > uint8_t reg_val;
> >--
> >1.6.5
>
> -Michael
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-19 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-19 14:46 [PATCH] mfd: Staticise __adp5520_ack_bits() Mark Brown
2009-10-19 15:09 ` Hennerich, Michael
2009-10-19 22:26 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox