From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, sameo@linux.intel.com,
tony@atomide.com
Subject: Re: [PATCH 1/4] MFD: twl4030: add twl4030_codec MFD as a new child to the core
Date: Tue, 20 Oct 2009 11:03:34 +0100 [thread overview]
Message-ID: <20091020100334.GA28592@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1255956140-4829-2-git-send-email-peter.ujfalusi@nokia.com>
On Mon, Oct 19, 2009 at 03:42:17PM +0300, Peter Ujfalusi wrote:
> New MFD child to twl4030 MFD device.
> This MFD device will be used by the drivers, which needs resources
> from the twl4030 codec like audio and vibra.
> The platform specific configuration data is passed along to the
> child drivers (audio, vibra).
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> +config TWL4030_CODEC
> + bool "Support codec part of the TWL4030 family chips"
This seems like something that users shouldn't really have to worry
about selecting explicitly - might it be better to have it selected by
the drivers that use it instead? It feels like it's an implementation
detail of the driver.
next prev parent reply other threads:[~2009-10-20 10:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 12:42 [PATCH 0/4] twl4030 codec as MFD device Peter Ujfalusi
2009-10-19 12:42 ` [PATCH 1/4] MFD: twl4030: add twl4030_codec MFD as a new child to the core Peter Ujfalusi
2009-10-19 12:42 ` [PATCH 2/4] OMAP: Platform support for twl4030_codec MFD Peter Ujfalusi
2009-10-19 12:42 ` [PATCH 3/4] ASoC: TWL4030: Only update the needed bits in *set_dai_sysclk Peter Ujfalusi
2009-10-19 12:42 ` [PATCH 4/4] ASoC: TWL4030: Driver registration via twl4030_codec MFD Peter Ujfalusi
2009-10-20 10:25 ` Mark Brown
2009-10-20 11:30 ` Peter Ujfalusi
2009-10-20 11:51 ` Mark Brown
2009-10-20 12:01 ` Peter Ujfalusi
2009-10-19 12:55 ` [PATCH 3/4] ASoC: TWL4030: Only update the needed bits in *set_dai_sysclk Mark Brown
2009-10-19 12:59 ` Peter Ujfalusi
2009-10-20 19:01 ` [PATCH 2/4] OMAP: Platform support for twl4030_codec MFD Tony Lindgren
2009-10-20 10:03 ` Mark Brown [this message]
2009-10-20 11:16 ` [alsa-devel] [PATCH 1/4] MFD: twl4030: add twl4030_codec MFD as a new child to the core Peter Ujfalusi
2009-10-21 23:13 ` Samuel Ortiz
2009-10-22 6:04 ` Peter Ujfalusi
2009-10-22 7:57 ` Samuel Ortiz
2009-10-22 10:55 ` Mark Brown
2009-10-22 11:02 ` Peter Ujfalusi
2009-10-21 8:56 ` [PATCH 0/4] twl4030 codec as MFD device Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020100334.GA28592@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox