public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Nix <nix@esperi.org.uk>
Cc: Matt Mackall <mpm@selenic.com>,
	linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: [PATCH] Allow renaming of network interfaces that are up.
Date: Wed, 21 Oct 2009 10:38:46 +0900	[thread overview]
Message-ID: <20091021103846.2f985ea1@s6510> (raw)
In-Reply-To: <87vdi9ew1h.fsf_-_@spindle.srvr.nix>

On Tue, 20 Oct 2009 19:54:02 +0100
Nix <nix@esperi.org.uk> wrote:

> The ancient restriction banning renaming of busy network interfaces appears
> to be purposeless. Everything that depends on a network interface's name is
> done under the dev_base_lock in any case.
> 
> This makes it much easier to use things like netconsole which bring up a
> network interface before userspace has started: presently these will cause
> interface renamings to fail, breaking any userspace that relies on renaming
> devices to avoid reliance on the potentially-unstable kernel-assigned name.
> 
> Signed-off-by: Nick Alcock <nix@esperi.org.uk>
> ---
>  net/core/dev.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)

This breaks quagga and other applications that track renames.

  parent reply	other threads:[~2009-10-21  1:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16 19:43 Keeping network device renaming working in the presence of netconsole? Nix
2009-10-16 19:57 ` Matt Mackall
2009-10-17 11:08   ` Nix
2009-10-20 18:54     ` [PATCH] Allow renaming of network interfaces that are up Nix
2009-10-21  0:39       ` David Miller
2009-10-21  1:38       ` Stephen Hemminger [this message]
2009-10-21  6:50         ` Nix
2009-10-23 19:50         ` [PATCH] Make it clear how to rename netconsole-used network interfaces Nix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091021103846.2f985ea1@s6510 \
    --to=shemminger@vyatta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=nix@esperi.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox