From: Arnd Bergmann <arndbergmann@googlemail.com>
To: John Kacur <jkacur@redhat.com>
Cc: Arnd Bergmann <arndbergmann@googlemail.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mattia Dongili <malattia@linux.it>
Subject: Re: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open
Date: Wed, 21 Oct 2009 15:16:20 +0200 [thread overview]
Message-ID: <200910211516.20614.arnd@arndb.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0910211226180.3526@localhost.localdomain>
On Wednesday 21 October 2009, John Kacur wrote:
> From 96872f13a510db69fbb32f9e956615cd826f8986 Mon Sep 17 00:00:00 2001
> From: John Kacur <jkacur@redhat.com>
> Date: Sun, 18 Oct 2009 23:49:49 +0200
> Subject: [PATCH] sony_pi: Remove the BKL from open and ioctl
>
> The BKL is in this function because of the BKL pushdown
> (see commit f8f2c79d594463427f7114cedb1555110d547d89)
>
> It is not needed here because the mutex_lock sonypi_device.lock
> provides the necessary locking.
>
> sonpi_misc_ioctl can be converted to unlocked ioctls since it relies on
> its own locking (the mutex sonypi_device.lock) and not the bkl
>
> Document that llseek is not needed by explictly setting it to no_llseek
>
> Signed-off-by: John Kacur <jkacur@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
This looks perfect to me now. Just a few hundred more of these,
and we're done with the drivers ;-)
next prev parent reply other threads:[~2009-10-21 13:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 21:54 [PATCH] sony_pi: Remove the BKL from sonypi_misc_open John Kacur
2009-10-19 4:19 ` Arnd Bergmann
2009-10-19 18:20 ` John Kacur
2009-10-19 22:00 ` Arnd Bergmann
2009-10-19 22:08 ` Arnd Bergmann
2009-10-21 0:06 ` John Kacur
2009-10-21 8:29 ` Arnd Bergmann
2009-10-21 10:27 ` John Kacur
2009-10-21 13:16 ` Arnd Bergmann [this message]
2009-10-22 2:52 ` Christoph Hellwig
2009-10-21 21:31 ` Frederic Weisbecker
2009-10-21 21:41 ` John Kacur
2009-10-21 21:55 ` Frederic Weisbecker
2009-10-21 22:06 ` John Kacur
2009-10-21 22:27 ` Frederic Weisbecker
2009-10-22 2:55 ` Christoph Hellwig
2009-10-22 13:50 ` Arnd Bergmann
2009-10-25 7:30 ` Christoph Hellwig
2009-10-19 22:30 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910211516.20614.arnd@arndb.de \
--to=arndbergmann@googlemail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=fweisbec@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox