From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753836AbZJVCr3 (ORCPT ); Wed, 21 Oct 2009 22:47:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753376AbZJVCr2 (ORCPT ); Wed, 21 Oct 2009 22:47:28 -0400 Received: from casper.infradead.org ([85.118.1.10]:43883 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753356AbZJVCr2 (ORCPT ); Wed, 21 Oct 2009 22:47:28 -0400 Date: Wed, 21 Oct 2009 19:48:22 -0700 From: Arjan van de Ven To: Andi Kleen Cc: john stultz , Andi Kleen , lkml , Mike Fulton , Sean Foley , Darren Hart Subject: Re: [RFC][PATCH] Add prctl to set sibling thread names Message-ID: <20091021194822.72895c46@infradead.org> In-Reply-To: <20091022004919.GT32470@one.firstfloor.org> References: <1256167297.4768.14.camel@localhost.localdomain> <20091021174804.3885db37@infradead.org> <20091022004919.GT32470@one.firstfloor.org> Organization: Intel X-Mailer: Claws Mail 3.7.2 (GTK+ 2.16.6; i586-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Oct 2009 02:49:19 +0200 Andi Kleen wrote: > > you're pretty much the first now who touches ->comm from > > not-the-thread-itself.... are you sure that is safe? > > It's not, there is no locking. On the other hand nothing should crash, > just users might see half rewritten data. .. with strings this is tricky though.. if the new string is longer than the old one the terminating zero might just be missed etc. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org