From: Samuel Ortiz <sameo@linux.intel.com>
To: Ilkka Koskinen <ilkka.koskinen@nokia.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [Resend PATCH 1/2] twl4030: Do not dereference null pointer in error path
Date: Thu, 22 Oct 2009 00:22:11 +0200 [thread overview]
Message-ID: <20091021222210.GC17796@sortiz.org> (raw)
In-Reply-To: <1256044973-14548-1-git-send-email-ilkka.koskinen@nokia.com>
Hi Ilkka,
On Tue, Oct 20, 2009 at 04:22:52PM +0300, Ilkka Koskinen wrote:
> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
Patch applied to my for-linus and for-next branches.
I'll try to get that one merged for 2.6.32.
Cheers,
Samuel.
> ---
> drivers/mfd/twl4030-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> index e424cf6..8cf0a02 100644
> --- a/drivers/mfd/twl4030-core.c
> +++ b/drivers/mfd/twl4030-core.c
> @@ -792,7 +792,7 @@ twl4030_probe(struct i2c_client *client, const struct i2c_device_id *id)
> twl->client = i2c_new_dummy(client->adapter,
> twl->address);
> if (!twl->client) {
> - dev_err(&twl->client->dev,
> + dev_err(&client->dev,
> "can't attach client %d\n", i);
> status = -ENOMEM;
> goto fail;
> --
> 1.6.0.4
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2009-10-21 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 13:22 [Resend PATCH 1/2] twl4030: Do not dereference null pointer in error path Ilkka Koskinen
2009-10-20 13:22 ` [Resend PATCH 2/2] twl4030: Enable low-power mode to 32kHz oscillator Ilkka Koskinen
2009-10-21 22:17 ` Samuel Ortiz
2009-10-22 11:05 ` Ilkka Koskinen
2009-10-21 22:22 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091021222210.GC17796@sortiz.org \
--to=sameo@linux.intel.com \
--cc=ilkka.koskinen@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox