From: Frederic Weisbecker <fweisbec@gmail.com>
To: John Kacur <jkacur@redhat.com>
Cc: Arnd Bergmann <arndbergmann@googlemail.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open
Date: Thu, 22 Oct 2009 00:27:59 +0200 [thread overview]
Message-ID: <20091021222758.GG4880@nowhere> (raw)
In-Reply-To: <alpine.LFD.2.00.0910220001470.3526@localhost.localdomain>
On Thu, Oct 22, 2009 at 12:06:32AM +0200, John Kacur wrote:
> Okay, I'm sure there is something wrong in this methodology, but it's late
> at night. At least for a ballpark figure, hopefully it's right.
>
> Files that mentions "file_operations" -
> Files that mention "file_operations" and mention "llseek"
> = 1172 - 596 = 572 (in my particular git repo)
>
> So, over 550 files that need to be set to no_llseek, locked_llseek, or
> unlocked_llseek. Yikes!
>
> [jkacur@tycho rt.linux.git]$ git-grep -l file_operations | grep -v
> Documentation | wc -l
> 1172
> [jkacur@tycho rt.linux.git]$ git-grep -l llseek $(git-grep -l
> file_operations | grep -v Documentation) | wc -l
> 596
>
So much?
Ok, a default_lseek pushdown patch wouldn't be accepted :)
Well, I guess we first need to fix the sites that explicitly use the
bkl, one by one, and after that probably propose a new locked version but
without the bkl...
next prev parent reply other threads:[~2009-10-21 22:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 21:54 [PATCH] sony_pi: Remove the BKL from sonypi_misc_open John Kacur
2009-10-19 4:19 ` Arnd Bergmann
2009-10-19 18:20 ` John Kacur
2009-10-19 22:00 ` Arnd Bergmann
2009-10-19 22:08 ` Arnd Bergmann
2009-10-21 0:06 ` John Kacur
2009-10-21 8:29 ` Arnd Bergmann
2009-10-21 10:27 ` John Kacur
2009-10-21 13:16 ` Arnd Bergmann
2009-10-22 2:52 ` Christoph Hellwig
2009-10-21 21:31 ` Frederic Weisbecker
2009-10-21 21:41 ` John Kacur
2009-10-21 21:55 ` Frederic Weisbecker
2009-10-21 22:06 ` John Kacur
2009-10-21 22:27 ` Frederic Weisbecker [this message]
2009-10-22 2:55 ` Christoph Hellwig
2009-10-22 13:50 ` Arnd Bergmann
2009-10-25 7:30 ` Christoph Hellwig
2009-10-19 22:30 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091021222758.GG4880@nowhere \
--to=fweisbec@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arndbergmann@googlemail.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox