From: Christoph Hellwig <hch@infradead.org>
To: Arnd Bergmann <arndbergmann@googlemail.com>
Cc: John Kacur <jkacur@redhat.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mattia Dongili <malattia@linux.it>
Subject: Re: [PATCH] sony_pi: Remove the BKL from sonypi_misc_open
Date: Wed, 21 Oct 2009 22:52:24 -0400 [thread overview]
Message-ID: <20091022025224.GA17438@infradead.org> (raw)
In-Reply-To: <200910211029.21702.arnd@arndb.de>
On Wed, Oct 21, 2009 at 10:29:21AM +0200, Arnd Bergmann wrote:
> Well, for this specific case, the driver does not actually need to seek,
> because the read function never looks at the position and there is no
> write function. For annotation purposes, IMHO we should have a simple
> '.llseek = no_llseek' in there.
Which is normal for character drivers. Even better you should use
nonseekable_open to also prevent pread/pwrite.
next prev parent reply other threads:[~2009-10-22 2:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 21:54 [PATCH] sony_pi: Remove the BKL from sonypi_misc_open John Kacur
2009-10-19 4:19 ` Arnd Bergmann
2009-10-19 18:20 ` John Kacur
2009-10-19 22:00 ` Arnd Bergmann
2009-10-19 22:08 ` Arnd Bergmann
2009-10-21 0:06 ` John Kacur
2009-10-21 8:29 ` Arnd Bergmann
2009-10-21 10:27 ` John Kacur
2009-10-21 13:16 ` Arnd Bergmann
2009-10-22 2:52 ` Christoph Hellwig [this message]
2009-10-21 21:31 ` Frederic Weisbecker
2009-10-21 21:41 ` John Kacur
2009-10-21 21:55 ` Frederic Weisbecker
2009-10-21 22:06 ` John Kacur
2009-10-21 22:27 ` Frederic Weisbecker
2009-10-22 2:55 ` Christoph Hellwig
2009-10-22 13:50 ` Arnd Bergmann
2009-10-25 7:30 ` Christoph Hellwig
2009-10-19 22:30 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022025224.GA17438@infradead.org \
--to=hch@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arndbergmann@googlemail.com \
--cc=fweisbec@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox