From: Ingo Molnar <mingo@elte.hu>
To: Erwan Velu <erwanaliasr1@gmail.com>,
Jeremy Fitzhardinge <jeremy@goop.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] dmi_check_system can generate Warnings when no DMI table is present
Date: Fri, 23 Oct 2009 13:03:23 +0200 [thread overview]
Message-ID: <20091023110323.GC10071@elte.hu> (raw)
In-Reply-To: <4AE178AF.3010804@gmail.com>
* Erwan Velu <erwanaliasr1@gmail.com> wrote:
> When running the Linux Kernel, on some systems that doesn't have any DMI
> table (like a Xen domU), some dmi_* calls can generates Warnings like :
>
>> / WARNING: at /usr/src/linux-2.6.29.1/drivers/firmware/dmi_scan.c:425/
>> / dmi_matches+0x7e/0x80()/
>> / dmi check: not initialized yet/
Empty DMI tables are common. What is not common is to call dmi_matches()
before the DMI strings code has initialized.
> Some users reported this error :
> http://lists.xensource.com/archives/html/xen-users/2009-04/msg00128.html
> https://qa.mandriva.com/show_bug.cgi?id=54775
Looks like a Xen bug. DMI matching functions should be called after that
code has initialized. The warning was added to catch such early calls.
Your patch works around that bug and the warning.
Ingo
next prev parent reply other threads:[~2009-10-23 11:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 9:34 [PATCH] dmi_check_system can generate Warnings when no DMI table is present Erwan Velu
2009-10-23 10:08 ` Daniel Walker
2009-10-23 10:34 ` Erwan Velu
2009-10-23 10:42 ` Daniel Walker
2009-10-23 10:46 ` Erwan Velu
2009-10-23 11:00 ` Ingo Molnar
2009-10-23 11:03 ` Ingo Molnar [this message]
2009-10-23 11:49 ` Erwan Velu
2009-10-23 12:47 ` Daniel Walker
2009-10-23 15:03 ` Erwan Velu
2009-10-23 15:09 ` Daniel Walker
2009-10-23 15:30 ` Ingo Molnar
2009-10-23 17:00 ` Jeremy Fitzhardinge
2009-10-23 17:04 ` Ingo Molnar
2009-10-23 17:31 ` Jeremy Fitzhardinge
2009-10-23 16:57 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091023110323.GC10071@elte.hu \
--to=mingo@elte.hu \
--cc=erwanaliasr1@gmail.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox