From: Ingo Molnar <mingo@elte.hu>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Young <hidave.darkstar@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC/PATCH] ratelimit: make output more useful
Date: Fri, 23 Oct 2009 16:55:09 +0200 [thread overview]
Message-ID: <20091023145509.GA13793@elte.hu> (raw)
In-Reply-To: <200910231458.11832.borntraeger@de.ibm.com>
* Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> Index: tip/include/linux/kernel.h
> ===================================================================
> --- tip.orig/include/linux/kernel.h
> +++ tip/include/linux/kernel.h
> @@ -16,6 +16,7 @@
> #include <linux/log2.h>
> #include <linux/typecheck.h>
> #include <linux/dynamic_debug.h>
> +#include <linux/ratelimit.h>
> #include <asm/byteorder.h>
> #include <asm/bug.h>
>
hm, this will cause circular dependencies - see:
3fff4c4: printk: Remove ratelimit.h from kernel.h
Any reason why it couldnt be pushed inside printk.c? We just need the
func string - not the pointer pass-in. That would also address some of
the call-site bloat.
Ingo
next prev parent reply other threads:[~2009-10-23 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 15:06 [RFC/PATCH] ratelimit: make output more useful Christian Borntraeger
2009-10-23 11:33 ` Ingo Molnar
2009-10-23 12:58 ` Christian Borntraeger
2009-10-23 13:11 ` Ingo Molnar
2009-10-23 14:51 ` Christian Borntraeger
2009-10-23 14:55 ` Ingo Molnar [this message]
2009-10-23 15:12 ` Christian Borntraeger
2009-10-23 21:17 ` Joe Perches
2009-10-24 1:04 ` [tip:branch?] ratelimit: Make suppressed output messages " tip-bot for Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091023145509.GA13793@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox