From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Paul Mackerras <paulus@samba.org>, Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH] perf timechart: Use pr_debug to report unknown header types
Date: Fri, 23 Oct 2009 16:31:07 -0200 [thread overview]
Message-ID: <20091023183107.GA4132@ghostprotocols.net> (raw)
In-Reply-To: <4AE1EE1B.2000500@linux.intel.com>
Em Fri, Oct 23, 2009 at 10:55:39AM -0700, Arjan van de Ven escreveu:
> Arnaldo Carvalho de Melo wrote:
>> It was using eprintf that checked if verbose was !zero, when I converted
>> to pr_*() I made the mistake of changing it to pr_warning which caused
>> 'perf timechart' output to be way too verbose.
>>
> nack...
>
> if you EVER hit one of these you have a very very serious problem.
> hiding that is never the right thing to do. I should make this a fatal
> event instead.
OK, so I actually fixed a bug as those messages weren't being noticed if
-v wasn't used! :-)
Please take a look at latest tip to see all those messages.
- Arnaldo
next prev parent reply other threads:[~2009-10-23 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 17:50 [PATCH] perf timechart: Use pr_debug to report unknown header types Arnaldo Carvalho de Melo
2009-10-23 17:55 ` Arjan van de Ven
2009-10-23 18:31 ` Arnaldo Carvalho de Melo [this message]
2009-10-23 18:37 ` Arjan van de Ven
2009-10-23 18:56 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091023183107.GA4132@ghostprotocols.net \
--to=acme@infradead.org \
--cc=arjan@linux.intel.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox