From: Andi Kleen <andi@firstfloor.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
john stultz <johnstul@us.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
Mike Fulton <fultonm@ca.ibm.com>,
Sean Foley <Sean_Foley@ca.ibm.com>,
Darren Hart <dvhltc@us.ibm.com>
Subject: Re: [RFC][PATCH] Add prctl to set sibling thread names
Date: Sat, 24 Oct 2009 05:54:38 +0200 [thread overview]
Message-ID: <20091024035438.GY32470@one.firstfloor.org> (raw)
In-Reply-To: <20091021194822.72895c46@infradead.org>
On Wed, Oct 21, 2009 at 07:48:22PM -0700, Arjan van de Ven wrote:
> On Thu, 22 Oct 2009 02:49:19 +0200
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > > you're pretty much the first now who touches ->comm from
> > > not-the-thread-itself.... are you sure that is safe?
> >
> > It's not, there is no locking. On the other hand nothing should crash,
> > just users might see half rewritten data.
>
> .. with strings this is tricky though.. if the new string is longer
> than the old one the terminating zero might just be missed etc.
Good point.
He needs to first set the last byte to zero to avoid that.
But better probably to do a proper lock on all readers. Or not add
this feature at all (does it have a strong use case?)
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-10-24 3:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 23:21 [RFC][PATCH] Add prctl to set sibling thread names john stultz
2009-10-22 0:28 ` Andi Kleen
2009-10-22 0:42 ` john stultz
2009-10-22 0:44 ` Andi Kleen
2009-10-22 0:48 ` Arjan van de Ven
2009-10-22 0:49 ` Andi Kleen
2009-10-22 2:48 ` Arjan van de Ven
2009-10-24 3:54 ` Andi Kleen [this message]
2009-10-26 23:56 ` john stultz
2009-10-22 0:52 ` john stultz
2009-10-22 2:00 ` Andrew Morton
2009-11-05 2:26 ` KOSAKI Motohiro
2009-11-05 5:17 ` Darren Hart
2009-11-05 5:22 ` KOSAKI Motohiro
2009-11-05 5:36 ` Darren Hart
2009-11-05 5:42 ` KOSAKI Motohiro
2009-11-05 19:11 ` john stultz
[not found] ` <OF5EE04242.D2B67AF2-ON85257665.0064683D-85257665.0068209E@ca.ibm.com>
2009-11-10 5:27 ` KOSAKI Motohiro
2009-11-10 20:16 ` john stultz
2009-11-11 0:04 ` KOSAKI Motohiro
-- strict thread matches above, loose matches on Subject: below --
2009-11-05 19:03 Sean Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091024035438.GY32470@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Sean_Foley@ca.ibm.com \
--cc=arjan@infradead.org \
--cc=dvhltc@us.ibm.com \
--cc=fultonm@ca.ibm.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox