public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: bart.hartgers@gmail.com
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bart Hartgers <bart.hartgers@gmail.com>
Subject: [PATCH 5/7] ark3116: (3rd try) Add cmset and break
Date: Sun, 25 Oct 2009 18:51:02 +0100	[thread overview]
Message-ID: <20091025175325.603584293@gmail.com> (raw)
In-Reply-To: 20091025175057.270011110@gmail.com

[-- Attachment #1: 0025_ark3116_break_cmset.patch --]
[-- Type: text/plain, Size: 2393 bytes --]

Signed-off-by: Bart Hartgers <bart.hartgers@gmail.com>
---
Index: linux-2.6.32-rc4/drivers/usb/serial/ark3116.c
===================================================================
--- linux-2.6.32-rc4.orig/drivers/usb/serial/ark3116.c	2009-10-18 16:20:17.000000000 +0200
+++ linux-2.6.32-rc4/drivers/usb/serial/ark3116.c	2009-10-18 16:20:20.000000000 +0200
@@ -570,6 +570,62 @@ static int ark3116_tiocmget(struct tty_s
 		(ctrl   & UART_MCR_OUT2 ? TIOCM_OUT2 : 0);
 }
 
+static int ark3116_tiocmset(struct tty_struct *tty, struct file *file,
+			unsigned set, unsigned clr)
+{
+	struct usb_serial_port *port = tty->driver_data;
+	struct ark3116_private *priv = usb_get_serial_port_data(port);
+	unsigned setmask = 0;
+	unsigned clrmask = 0;
+
+	if (set & TIOCM_RTS)
+		setmask |= UART_MCR_RTS;
+	if (set & TIOCM_DTR)
+		setmask |= UART_MCR_DTR;
+	if (set & TIOCM_OUT1)
+		setmask |= UART_MCR_OUT1;
+	if (set & TIOCM_OUT2)
+		setmask |= UART_MCR_OUT2;
+	if (clr & TIOCM_RTS)
+		clrmask |= UART_MCR_RTS;
+	if (clr & TIOCM_DTR)
+		clrmask |= UART_MCR_DTR;
+	if (clr & TIOCM_OUT1)
+		clrmask |= UART_MCR_OUT1;
+	if (clr & TIOCM_OUT2)
+		clrmask |= UART_MCR_OUT2;
+
+	ark3116_atomic_set_clear(setmask, clrmask, &priv->mcr);
+
+	/* unfortunately, we need the mutex, to make sure that the value
+	 * in priv->mcr is actually the one that is in the hardware
+	 */
+
+	mutex_lock(&priv->lock);
+	ark3116_write_reg(port->serial, UART_MCR, atomic_read(&priv->mcr));
+	mutex_unlock(&priv->lock);
+
+	return 0;
+}
+
+static void ark3116_break_ctl(struct tty_struct *tty, int break_state)
+{
+	struct usb_serial_port *port = tty->driver_data;
+	struct ark3116_private *priv = usb_get_serial_port_data(port);
+
+	/* LCR is also used for other things: protect access */
+	mutex_lock(&priv->lock);
+
+	if (break_state)
+		priv->lcr |= UART_LCR_SBC;
+	else
+		priv->lcr &= UART_LCR_SBC;
+
+	ark3116_write_reg(port->serial, UART_LCR, priv->lcr);
+
+	mutex_unlock(&priv->lock);
+}
+
 static struct usb_driver ark3116_driver = {
 	.name =		"ark3116",
 	.probe =	usb_serial_probe,
@@ -592,8 +648,10 @@ static struct usb_serial_driver ark3116_
 	.init_termios =		ark3116_init_termios,
 	.ioctl =		ark3116_ioctl,
 	.tiocmget =		ark3116_tiocmget,
+	.tiocmset =		ark3116_tiocmset,
 	.open =			ark3116_open,
 	.close =		ark3116_close,
+	.break_ctl = 		ark3116_break_ctl,
 };
 
 static int __init ark3116_init(void)

-- 

  parent reply	other threads:[~2009-10-25 17:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-25 17:50 [PATCH 0/7] ark3116: (3rd try) driver rework bart.hartgers
2009-10-25 17:50 ` [PATCH 1/7] ark3116: (3rd try) Setup some basic infrastructure for new ark3116 driver bart.hartgers
2009-10-27 17:46   ` Greg KH
2009-10-27 21:35     ` Bart Hartgers
2009-10-27 22:11       ` Greg KH
2009-10-25 17:50 ` [PATCH 2/7] ark3116: (3rd try) Make existing functions 16450-aware and add close and release functions bart.hartgers
2009-10-25 19:56   ` Oliver Neukum
2009-10-25 17:51 ` [PATCH 3/7] ark3116: (3rd try) Replace cmget bart.hartgers
2009-10-25 19:52   ` Oliver Neukum
2009-10-25 19:56     ` Bart Hartgers
2009-10-25 22:08       ` Oliver Neukum
2009-10-25 17:51 ` [PATCH 4/7] ark3116: (3rd try) Add atomic set-and-clear function bart.hartgers
2009-10-25 17:51 ` bart.hartgers [this message]
2009-10-25 17:51 ` [PATCH 6/7] ark3116: (3rd try) Callbacks for interrupt and bulk read bart.hartgers
2009-10-25 17:51 ` [PATCH 7/7] ark3116: (3rd try) Cleanup of now unneeded functions bart.hartgers
2009-10-25 17:53 ` [PATCH 0/7] ark3116: (3rd try) driver rework Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091025175325.603584293@gmail.com \
    --to=bart.hartgers@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox