Re: [PATCH] i2c-scmi: Quirk to work on IBM machines with broken BIOSes

Crane Cai
2009-10-21T02:30:34Z

Hi Darrick,

On Tue, Oct 20, 2009 at 04:11:49PM -0700, Darrick J. Wong wrote:
> On some old IBM workstations and desktop computers, the BIOS presents in the
> DSDT an SMBus object that is missing the HID identifier that the i2c-scmi
> driver looks for. It also omits the leading "_" in the method names (it should
> be _SBR, not SBR_). Modify the ACPI device scan code to insert the missing HID
> if it finds an IBM system with such an object, and modify the i2c-scmi driver
> to handle the odd method names.
I have a suggestion:
You can need not to add quirk in acpi part, instead you can add your ACPI device
HID in i2c-scmi with your specificied methods set.

--
Best Regards,
- Crane