From: Theodore Tso <tytso@mit.edu>
To: Pavel Machek <pavel@ucw.cz>
Cc: Linux Kernel Developers List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext2: Avoid WARN() messages when failing to write to the superblock
Date: Mon, 26 Oct 2009 00:08:10 -0400 [thread overview]
Message-ID: <20091026040810.GE18523@mit.edu> (raw)
In-Reply-To: <20091025062128.GA1391@ucw.cz>
On Sun, Oct 25, 2009 at 07:21:28AM +0100, Pavel Machek wrote:
> > + if (buffer_write_io_error(sbh)) {
> > + /*
> > + * Oh, dear. A previous attempt to write the
> > + * superblock failed. This could happen because the
> > + * USB device was yanked out. Or it could happen to
> > + * be a transient write error and maybe the block will
> > + * be remapped. Nothing we can do but to retry the
> > + * write and hope for the best.
> > + */
> > + printk(KERN_ERR "EXT2-fs: %s previous I/O error to "
> > + "superblock detected", sb->s_id);
>
> KERN_ALERT/KERN_CRITICAL?
Based on kerneloops.org logs, it's apparently very frequent that
clueless lusers rip out USB drives without bothering to unmount them
first. (Or people by crappy laptops where the SD cards sticks out
slightly and is easily jostled.) It's not clear we really want to be
issueing KERN_ALERT or KERN_CRITICAL messages when this very common
event happens.
- TRed
next prev parent reply other threads:[~2009-10-26 4:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 5:22 [PATCH] ext2: Avoid WARN() messages when failing to write to the superblock Theodore Ts'o
2009-10-25 6:21 ` Pavel Machek
2009-10-26 4:08 ` Theodore Tso [this message]
2009-10-26 7:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026040810.GE18523@mit.edu \
--to=tytso@mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox