Re: [PATCH] checkpatch.pl: Allow > 80 char lines for logging functions not just printk

Andy Whitcroft
2009-10-26T11:16:41Z

On Fri, Oct 02, 2009 at 05:10:04PM -0700, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 87bbb8b..ae74ab1 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -186,6 +186,14 @@ our $typeTypedefs = qr{(?x:
> atomic_t
> )};
>
> +our $logFunctions = qr{(?x:
> + printk|
> + pr_(debug|dbg|vdbg|devel|info|warning|err|notice|alert|crit|emerg|cont)|
> + dev_(printk|dbg|vdbg|info|warn|err|notice|alert|crit|emerg|WARN)|
> + WARN|
> + panic
> +)};
> +
> our @typeList = (
> qr{void},
> qr{(?:unsigned\s+)?char},
> @@ -1367,7 +1375,7 @@ sub process {
> #80 column limit
> if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
> $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
> - $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
> + $line !~ /^\+\s*$logFunctions\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
> $length > 80)
> {
> WARN("line over 80 characters\n" . $herecurr);

Yep that looks reasonable to me. I have a slightly modified version in
my tree. Will be in the next batch to akpm.

http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing

-apw