From: Jens Axboe <jens.axboe@oracle.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Corrado Zoccolo <czoccolo@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC 0/4] cfq: implement merging and breaking up of cfq_queues
Date: Mon, 26 Oct 2009 14:34:22 +0100 [thread overview]
Message-ID: <20091026133422.GF10727@kernel.dk> (raw)
In-Reply-To: <x49ws2iz3gg.fsf@segfault.boston.devel.redhat.com>
On Mon, Oct 26 2009, Jeff Moyer wrote:
> Corrado Zoccolo <czoccolo@gmail.com> writes:
>
> > Hi Jeff,
> > this series looks good.
>
> Hi, Corrado. Thanks again for the review!
>
> > I like in particular the fact that you move seekiness detection in the cfqq.
> > This can help with processes that issue sequential reads and seeky
> > writes, or vice versa.
> > Probably, also the think time could be made per-cfqq, so that the
> > decision whether we should idle for a given cfqq is more precise.
>
> I'll have to think about that one. It would be good to know Jens'
> opinion on the matter, too.
Your implementation looks fine, as usual I'm mostly worried about
performance impact and suitability (I hate having to work around
issues). But the win is so large in some cases that we should just go
ahead and merge it for .33, so I'll queue it up.
It would be nice to fix the in-kernel problem with NFS, since that is
doable.
--
Jens Axboe
next prev parent reply other threads:[~2009-10-26 13:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 21:14 [PATCH/RFC 0/4] cfq: implement merging and breaking up of cfq_queues Jeff Moyer
2009-10-23 21:14 ` [PATCH 1/4] cfq: calculate the seek_mean per cfq_queue not per cfq_io_context Jeff Moyer
2009-10-23 21:14 ` [PATCH 2/4] cfq: merge cooperating cfq_queues Jeff Moyer
2009-10-23 21:14 ` [PATCH 3/4] cfq: change the meaning of the cfqq_coop flag Jeff Moyer
2009-10-23 21:14 ` [PATCH 4/4] cfq: break apart merged cfqqs if they stop cooperating Jeff Moyer
2009-10-24 20:08 ` [PATCH/RFC 0/4] cfq: implement merging and breaking up of cfq_queues Corrado Zoccolo
2009-10-26 11:40 ` Jens Axboe
2009-10-26 13:20 ` Corrado Zoccolo
2009-10-26 13:28 ` Jens Axboe
2009-10-26 13:31 ` Jeff Moyer
2009-10-26 13:34 ` Jens Axboe [this message]
2009-10-26 15:01 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026133422.GF10727@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=czoccolo@gmail.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox