From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com,
dipankar@in.ibm.com, akpm@linux-foundation.org,
mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org,
dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de,
peterz@infradead.org, rostedt@goodmis.org,
Valdis.Kletnieks@vt.edu, dhowells@redhat.com, avi@redhat.com,
mtosatti@redhat.com
Subject: Re: [PATCH tip/core/rcu 6/6] rcu: Simplify creating of lockdep class for root rcu_node
Date: Mon, 26 Oct 2009 10:13:30 -0700 [thread overview]
Message-ID: <20091026171330.GC6317@linux.vnet.ibm.com> (raw)
In-Reply-To: <20091026065007.GA24908@elte.hu>
On Mon, Oct 26, 2009 at 07:50:07AM +0100, Ingo Molnar wrote:
>
> * Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
>
> > From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >
> > Use lockdep_set_class() to simplify the code and to avoid any additional
> > overhead in the !LOCKDEP case.
> >
> > Signed-off-by: Peter Zijlstra <peterz@infradead.org>
> > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> This signoff order is wrong - first signoff line must be the author of
> the patch. (which is a pretty general rule with only rare exceptions)
>
> This patch was from Peter originally, right? In such cases please add:
>
> From: Peter Zijlstra <peterz@infradead.org>
>
> To the head of the patch. Or, if Peter acked it, add:
>
> Acked-by: Peter Zijlstra <peterz@infradead.org>
>
> SOB lines are strictly only added by people who send patches to you -
> i.e. it records the patch handling pathway.
I will resubmit with this fixed up, apologies for my confusion.
Thanx, Paul
next prev parent reply other threads:[~2009-10-26 17:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 2:02 [PATCH tip/core/rcu 0/6] rcu: Tiny RCU, expedited RCU, rcutorture fixes, lockdep simplification Paul E. McKenney
2009-10-26 2:03 ` [PATCH tip/core/rcu 1/6] rcu: The Bloatwatch Edition, v8 Paul E. McKenney
2009-10-26 11:36 ` [tip:core/rcu] rcu: "Tiny RCU", The Bloatwatch Edition tip-bot for Paul E. McKenney
2009-10-26 11:37 ` [tip:core/rcu] rcu: Do tiny cleanups in rcutiny tip-bot for Ingo Molnar
2009-10-26 16:29 ` Paul E. McKenney
2009-10-26 2:03 ` [PATCH tip/core/rcu 2/6] rcu: Add synchronize_srcu_expedited() Paul E. McKenney
2009-10-26 11:36 ` [tip:core/rcu] " tip-bot for Paul E. McKenney
2009-10-26 2:03 ` [PATCH tip/core/rcu 3/6] rcu: add synchronize_srcu_expedited() to the rcutorture test suite Paul E. McKenney
2009-10-26 11:37 ` [tip:core/rcu] rcu: Add " tip-bot for Paul E. McKenney
2009-10-26 2:03 ` [PATCH tip/core/rcu 4/6] rcu: add synchronize_srcu_expedited() to the documentation Paul E. McKenney
2009-10-26 11:37 ` [tip:core/rcu] rcu: Add " tip-bot for Paul E. McKenney
2009-10-26 2:03 ` [PATCH tip/core/rcu 5/6] rcu: Improve rcutorture diagnostics when bad torture_type specified Paul E. McKenney
2009-10-26 11:37 ` [tip:core/rcu] " tip-bot for Paul E. McKenney
2009-10-26 2:03 ` [PATCH tip/core/rcu 6/6] rcu: Simplify creating of lockdep class for root rcu_node Paul E. McKenney
2009-10-26 6:50 ` Ingo Molnar
2009-10-26 17:13 ` Paul E. McKenney [this message]
2009-10-26 8:34 ` Lai Jiangshan
2009-10-26 17:12 ` Paul E. McKenney
2009-10-26 2:27 ` [PATCH tip/core/rcu 0/6] rcu: Tiny RCU, expedited RCU, rcutorture fixes, lockdep simplification Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026171330.GC6317@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=niv@us.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox